Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: OApackage: A Python package for generation and analysis of orthogonal arrays and conference designs #1079
Comments
whedon
added
the
pre-review
label
Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
whedon
added
Batchfile
CMake
PowerShell
labels
Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon assign @danielskatz as editor |
This comment has been minimized.
This comment has been minimized.
OK, the editor is @danielskatz |
whedon
assigned
danielskatz
Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
eendebakpt
commented
Nov 12, 2018
@whedon commands |
This comment has been minimized.
This comment has been minimized.
Here are some things you can ask me to do:
|
This comment has been minimized.
This comment has been minimized.
eendebakpt
commented
Nov 12, 2018
@whedon list reviewers |
This comment has been minimized.
This comment has been minimized.
Here's the current list of reviewers: https://bit.ly/joss-reviewers |
This comment has been minimized.
This comment has been minimized.
eendebakpt
commented
Nov 13, 2018
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eendebakpt
commented
Nov 13, 2018
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eendebakpt
commented
Nov 13, 2018
@danielskatz Thanks for picking this up. I updated the references in the paper. As for reviewers: Based on Python/C++ experience: pragyansmita, katyhuff or djmitche |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
I can definitely take a look! |
This comment has been minimized.
This comment has been minimized.
This is somewhat outside my wheelhouse conceptually and I'm a bit overcommitted at the moment, so I should be a reviewer of last resort for this one. Hopefully @pragyansmita or @tupi are available. If not, let me know. |
This comment has been minimized.
This comment has been minimized.
For my reference, since I haven't reviewed anything here since volunteering, these are the reviewer guidelines. |
This comment has been minimized.
This comment has been minimized.
Aside from the community guidelines noted above, everything looks on the up-and-up. I would like a general pointer in the docs or README to what the heck a Conference Design is -- it's a particularly difficult thing to search for, since there are a lot of Design Conferences out there. A quick sentence about how this might be used would be helpful, too. The paragraph beginning "As an example" in [EN95] was tantalizing, but of course I can't see the second page! I took some extra time to stare at the I perused the C++ and Python source. I didn't look at everything, and certainly didn't understand the meaning of much of what I saw. But the code looks well-structured and well-documented. Nothing seems alarming or suggestive of any systemic issues. This looks like solid, efficient numerical software. |
This comment has been minimized.
This comment has been minimized.
Thanks @djmitche - let me try to find another reviewer, then I'll open a review issue, where you can check off stuff like you've started to do above... |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Update: I've found another reviewer via email, and once I get his github username, I will add him and start the review. |
This comment has been minimized.
This comment has been minimized.
whedon
assigned
danielskatz and
djmitche
and unassigned
danielskatz
Nov 26, 2018
This comment has been minimized.
This comment has been minimized.
OK, the reviewer is @djmitche |
This comment has been minimized.
This comment has been minimized.
@whedon add @tanaken-basis as reviewer |
whedon
assigned
danielskatz and
djmitche
and unassigned
djmitche and
danielskatz
Nov 26, 2018
This comment has been minimized.
This comment has been minimized.
OK, @tanaken-basis is now a reviewer |
This comment has been minimized.
This comment has been minimized.
@whedon start review |
This comment has been minimized.
This comment has been minimized.
OK, I've started the review over in #1097. Feel free to close this issue now! |
whedon commentedNov 12, 2018
•
edited
Submitting author: @eendebakpt (Pieter Eendebak)
Repository: https://github.com/eendebakpt/oapackage
Version: 2.5.1
Editor: @danielskatz
Reviewers: @djmitche, @tanaken-basis
Author instructions
Thanks for submitting your paper to JOSS @eendebakpt. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@eendebakpt if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: