New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: OApackage: A Python package for generation and analysis of orthogonal arrays and conference designs #1079

Closed
whedon opened this Issue Nov 12, 2018 · 32 comments

Comments

Projects
None yet
6 participants
@whedon
Collaborator

whedon commented Nov 12, 2018

Submitting author: @eendebakpt (Pieter Eendebak)
Repository: https://github.com/eendebakpt/oapackage
Version: 2.5.1
Editor: @danielskatz
Reviewers: @djmitche, @tanaken-basis

Author instructions

Thanks for submitting your paper to JOSS @eendebakpt. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@eendebakpt if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Nov 12, 2018

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 12, 2018

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 12, 2018

Attempting PDF compilation. Reticulating splines etc...
@arfon

This comment has been minimized.

Member

arfon commented Nov 12, 2018

👋 @danielskatz - would you be willing to edit this submission for JOSS?

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 12, 2018

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 12, 2018

👋 @eendebakpt

  1. there seem to be a bunch of reference problems in the compiled PDF. If you fix the .md, you should be able recompile here by adding a new comment that starts with:
    @whedon generate pdf

  2. Can you suggest reviewers, perhaps from this list of people who have already agreed to review for JOSS, or from outside the list as well. I think it would be good to get one reviewer who can check the Python API as well as the C++ source.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 12, 2018

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 12, 2018

OK, the editor is @danielskatz

@eendebakpt

This comment has been minimized.

eendebakpt commented Nov 12, 2018

@whedon commands

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 12, 2018

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Compile the paper
@whedon generate pdf

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper from a custom git branch
@whedon generate pdf from branch custom-branch-name

@eendebakpt

This comment has been minimized.

eendebakpt commented Nov 12, 2018

@whedon list reviewers

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 12, 2018

Here's the current list of reviewers: https://bit.ly/joss-reviewers

@eendebakpt

This comment has been minimized.

eendebakpt commented Nov 13, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 13, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 13, 2018

@eendebakpt

This comment has been minimized.

eendebakpt commented Nov 13, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 13, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 13, 2018

@eendebakpt

This comment has been minimized.

eendebakpt commented Nov 13, 2018

@danielskatz Thanks for picking this up. I updated the references in the paper. As for reviewers:

Based on Python/C++ experience: pragyansmita, katyhuff or djmitche
Based on Python and content experience: tupi

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 13, 2018

👋 @pragyansmita @katyhuff @djmitche @tupi - Would a couple of you be willing to review this submission?

@djmitche

This comment has been minimized.

Collaborator

djmitche commented Nov 13, 2018

I can definitely take a look!

@katyhuff

This comment has been minimized.

Member

katyhuff commented Nov 13, 2018

This is somewhat outside my wheelhouse conceptually and I'm a bit overcommitted at the moment, so I should be a reviewer of last resort for this one. Hopefully @pragyansmita or @tupi are available. If not, let me know.

@djmitche

This comment has been minimized.

Collaborator

djmitche commented Nov 18, 2018

For my reference, since I haven't reviewed anything here since volunteering, these are the reviewer guidelines.

@djmitche

This comment has been minimized.

Collaborator

djmitche commented Nov 19, 2018

Aside from the community guidelines noted above, everything looks on the up-and-up. I would like a general pointer in the docs or README to what the heck a Conference Design is -- it's a particularly difficult thing to search for, since there are a lot of Design Conferences out there. A quick sentence about how this might be used would be helpful, too. The paragraph beginning "As an example" in [EN95] was tantalizing, but of course I can't see the second page!

I took some extra time to stare at the LICENSE file, as it identifies some separately-licensed bits (the MPL2 bits, in particular, concern me). However, I think this is fine: anyone using this software in an open-source context will automatically be compliant with the MPL2 license, and anyone using it in a proprietary context has the information they need available to them in LICENSE. Whether that means that the package is essentially MPL2-licensed is neither something I can figure out, nor particularly important to the review. Which is a long way of saying that it's nice to see proper attention paid to licensing, and I see nothing to be concerned about here.

I perused the C++ and Python source. I didn't look at everything, and certainly didn't understand the meaning of much of what I saw. But the code looks well-structured and well-documented. Nothing seems alarming or suggestive of any systemic issues. This looks like solid, efficient numerical software.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 19, 2018

Thanks @djmitche - let me try to find another reviewer, then I'll open a review issue, where you can check off stuff like you've started to do above...
Sorry for the delay.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 21, 2018

👋 @pragyansmita & @tupi - I'm checking again to see if one of you might be willing to be the second reviewer for this submission...

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 25, 2018

Update: I've found another reviewer via email, and once I get his github username, I will add him and start the review.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 26, 2018

@whedon assign @djmitche as reviewer

@whedon whedon assigned danielskatz and djmitche and unassigned danielskatz Nov 26, 2018

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 26, 2018

OK, the reviewer is @djmitche

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 26, 2018

@whedon add @tanaken-basis as reviewer

@whedon whedon assigned danielskatz and djmitche and unassigned djmitche and danielskatz Nov 26, 2018

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 26, 2018

OK, @tanaken-basis is now a reviewer

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Nov 26, 2018

@whedon start review

@whedon

This comment has been minimized.

Collaborator

whedon commented Nov 26, 2018

OK, I've started the review over in #1097. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment