Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upComments
whedon
added
the
pre-review
label
Oct 22, 2018
This comment has been minimized.
This comment has been minimized.
|
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@TheChymera : I had a quick look at your submission, and I'm a little concerned about how a reviewer might approach this. The software is meant to be used with a device, the COSplayer, which is custom-built open-source hardware using a PyBoard. Do you provide any way for the software to be tested without this device? It would be useful, for example, to have synthetic data and a toy workflow that could be executed to demo the functionality, without the hardware. Is that possible? |
This comment has been minimized.
This comment has been minimized.
TheChymera
commented
Nov 25, 2018
|
ugh, not really, the software interacts with the hardware. At the very least you would need a pyboard, and then you could observe the LED pattern. If even that is unavailable you would need a software emulator for the pyboard, which is very much nontrivial to produce and would add little value to the project (others have attempted to make such emulators and given up). Unless such an emulator is guaranteed to be perfect (which is impossible), errors appearing in this use case might as well be errors with the emulator. What I could offer, if a pyboard truly is unavailable, is to mail a pyboard to the reviewer (which we would like to have back :) ). We had hoped that an interested reviewer might actually attempt to reproduce the device as per our complete video guide [1,2]. The best part about this is that the reviewer would then get to keep and use the COSplayer, which is a really cool device! |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
|
whedon commentedOct 22, 2018
Submitting author: @TheChymera (Horea-Ioan Ioanas)
Repository: https://github.com/IBT-FMI/COSplay/
Version: 1.1.1
Editor: Pending
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @TheChymera. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@TheChymera if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: