/vossanto

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The regex in the paper is missing the opening parenthesis #1

Open
Daniel-Mietchen opened this Issue Feb 3, 2019 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Daniel-Mietchen
@Daniel-Mietchen
Copy link

Daniel-Mietchen commented Feb 3, 2019

In the paper at https://doi.org/10.1093/llc/fqy087 , the regex is given as

\\bthe\\s+([\\w.,'-]+\\s+){1,5}?of\\b)

(directly followed by a . to indicate the end of the sentence but that is not made clear), which misses the opening parenthesis, as per

vossanto/theof/theof.py

Line 64 in 986b7b2

5: re.compile("(\\bthe\\s+([\\w.,'-]+\\s+){1,5}?of\\b)", re.UNICODE)
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment