New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Sigma.js Minimum Node Size #190

Closed
ianmilligan1 opened this Issue Aug 30, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@ianmilligan1
Member

ianmilligan1 commented Aug 30, 2018

Is your feature request related to a problem? Please describe.
With new GraphPass, the minimum node size needs to be reduced. Nodes seem slightly larger with the new approach to node scaling (as discussed on this Pull Request. I've tested about thirty diagrams in sigma.js and I think changing the min node size from 3 to 1 would be ideal with this new approach.

Describe the solution you'd like
In graphs.js (in app/assets/javascripts), change:

        minNodeSize: 3,

to

        minNodeSize: 1,

This should not be done until new GraphPass is brought into production.

Additional context
I've been putting screenshots into the Slack channel, but for example:

Collection 10004

10004 - nodes maybe too big
Figure 1: Original, minNodeSize of 3. Note that the clusters of nodes run together, making the mouse over too difficult.

screen shot 2018-08-30 at 10 03 25 am
Figure 2: Suggested solution, minNodeSize of 1. Note that clusters of nodes are more legible, making a mouse over easy as in Figure 3.

screen shot 2018-08-30 at 10 03 27 am
Figure 3: With mouse over

Collection 10371

10371 - nodes maybe too big
Figure 1: Same as above, minNodeSize of 3

screen shot 2018-08-30 at 10 06 26 am
Figure 2: minNodeSize of 1, makes selecting nodes easier

screen shot 2018-08-30 at 10 06 36 am
Figure 3: minNodeSize of 1, able to navigate diagram

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 2, 2018

Member

FYI: I'll have to manually run GraphPass on all existing graphml files in production once we do this.

Member

ruebot commented Sep 2, 2018

FYI: I'll have to manually run GraphPass on all existing graphml files in production once we do this.

@ruebot ruebot closed this in 553cd30 Sep 2, 2018

@ianmilligan1

This comment has been minimized.

Show comment
Hide comment
@ianmilligan1

ianmilligan1 Sep 2, 2018

Member

It will update automatically as the change is to sigma and not the files it’s running on - so no need to rerun graphpass!

Member

ianmilligan1 commented Sep 2, 2018

It will update automatically as the change is to sigma and not the files it’s running on - so no need to rerun graphpass!

@ianmilligan1

This comment has been minimized.

Show comment
Hide comment
@ianmilligan1

ianmilligan1 Sep 2, 2018

Member

(But yeah, once the graphpass version is updated, that is true... long weekend brain not connecting the separate issues and PRs)

Member

ianmilligan1 commented Sep 2, 2018

(But yeah, once the graphpass version is updated, that is true... long weekend brain not connecting the separate issues and PRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment