Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: COSplay: Contrast Optimized Stimulation Player #1171
Comments
whedon
assigned
arokem
Jan 14, 2019
whedon
added
the
review
label
Jan 14, 2019
whedon
referenced this issue
Jan 14, 2019
Closed
[PRE REVIEW]: COSplay: Contrast Optimized Stimulation Player #1039
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @damaggu it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey @effigies/@damaggu: have you had a chance to take a look? |
This comment has been minimized.
This comment has been minimized.
Ah, no. Thanks for the reminder. I'll make time this week. |
This comment has been minimized.
This comment has been minimized.
RE conflicts of interest, I've met @TheChymera in person within the last 4 years (Scipy 2017), and we've collaborated (mostly in the form of PR review) separately on Nipype. Also, this week piled up on me, and there's no chance I'll have a proper review today. I will aim for next Wednesday. |
This comment has been minimized.
This comment has been minimized.
Hi @effigies: the in-person meeting does not constitute a COI, in my opinion. I am not sure whether the software collaboration constitutes COI, though. Let's check with the EIC. @arfon : the author of this paper and the reviewer have collaborated in code review on another software package (nipype, mentioned above). Does this constitute a COI that should disqualify @effigies from reviewing this paper? It is "work that is funded or published" only in the sense that that software project receives funding and is publicly available, but I believe that the two have not been paid from the same source of funding or been co-authors on any publication resulting from that software (but may in the future be). Should I find another reviewer for this? |
This comment has been minimized.
This comment has been minimized.
Neither of these are a COI. |
This comment has been minimized.
This comment has been minimized.
damaggu
commented
Feb 11, 2019
@arokem, @danielskatz Sorry, I'll make some time this week as well. Regarding COI: I'm actually collaborating with @TheChymera on other projects, but haven't been involved in the development of COSplay. Does this constitute a problem? Regards |
This comment has been minimized.
This comment has been minimized.
Yes, @arokem should try to find another reviewer in this case. |
whedon commentedJan 14, 2019
•
edited by effigies
Submitting author: @TheChymera (Horea-Ioan Ioanas)
Repository: https://github.com/IBT-FMI/COSplay/
Version: 1.1.1
Editor: @arokem
Reviewer: @damaggu, @effigies
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@damaggu & @effigies, please carry out your reviews in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arokem know.
Review checklist for @damaggu
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @effigies
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?