Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate GaleGDC.js #1908
Conversation
This comment has been minimized.
This comment has been minimized.
Could you specify for which Gale databases this will work and/or has been tested? We're seeing very different page structures for different Gale databases and have two well-working translators covering most (all?) of those except GDC (which the previous version of this one covered.) |
This comment has been minimized.
This comment has been minimized.
Hi Sebastian,
My name is Jim Miazek and I am a Software Engineer at Cengage Learning. My team supports the development for all Gale Databases.
There are 3 connectors for Gale Databases. Our team supports GaleGDC.js and it supports 30+ archive products. We plan to extend that support for over 100 more. The problem that we are running into is that there are 2 other web translators (Galegroup.js and Gale Databases.js) that are not supported by us. This is important because the documents from these translators are not correct and are attributed to Google Scholar links.
Instead we will support with *auth-free* links for our customers using Zotero. This will be a better experience for our customers ensuring that the provided links will always work for them.
Our code is test protected and is under 100% code coverage – note, we don’t publish our Spec. Also, we follow our eslint rules before publishing our code.
We ask that the “Galegroup.js” and “Gale Databases.js” be removed. The links published by Zotero from these two translators are unauthorized for use.
Sincerely,
Jim Miazek
Software Engineer IV
Jim.miazek@cengage.com<mailto:Jim.miazek@cengage.com>
Gale, A Cengage Company
27500 Drake Road, Farmington Hills, Michigan 48331
From: Sebastian Karcher <notifications@github.com>
Reply-To: zotero/translators <reply@reply.github.com>
Date: Tuesday, March 12, 2019 at 12:13 PM
To: zotero/translators <translators@noreply.github.com>
Cc: "Miazek, Jim" <Jim.Miazek@cengage.com>, Author <author@noreply.github.com>
Subject: Re: [zotero/translators] Update GaleGDC.js (#1908)
Could you specify for which Gale databases this will work and/or has been tested? We're seeing very different page structures for different Gale databases and have two well-working translators covering most (all?) of those except GDC (which the previous version of this one covered.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1908 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AuNWwstpaZz-_rv2PWvN58UTj12-jpJ5ks5vV9H0gaJpZM4brLeR>.
|
This comment has been minimized.
This comment has been minimized.
So what next? Your eslintrc rules are different. No problem, we can change. But most of these errors have to do with the JSON object that is declared before the code. What do we do now? |
This comment has been minimized.
This comment has been minimized.
don't worry about the automated errors for now. I'll need to review the code & performance first |
This comment has been minimized.
This comment has been minimized.
As mentioned earlier, we would like the other translators taken down. The links used are not correct and need to be customized to our user's login. Our products will be under going a migration to new platforms with different domain including in some cases, new path and URI. We would like to ensure that the experience will work for all of our products, not just a certain few. That is why, as a company, we intend to support Zotero web translation, ourselves. If you wish to speak in conference then please contact me at jim.miazek@cengage.com. |
This comment has been minimized.
This comment has been minimized.
I'm absolutely happy to take the existing translators down provided yours produce equivalent or higher-quality import, yes. (Not sure what links you're referring to, though? Just the test cases?) |
This comment has been minimized.
This comment has been minimized.
The problem is that the targets (in these translators) from these other connecters are matching our production servers which we host 170 database applications. The URLs used and are saved in Zotero are incorrect -- They contain "&sid=googlescholar" in the URL. These links need to be removed ASAP! Therefore these translators need to be removed ASAP! |
This comment has been minimized.
This comment has been minimized.
I assume you don't blindly accept other people's code into your production platform and neither does Zotero. We'll review this as speedily as possible, but we also won't rush code review cc @dstillman . As I say above, I'll look at your code and see how it performs and am happy to accept it provided it provides the same quality and coverage of import. If there are severe problems with Zotero's Gale import, we will obviously act with the appropriate speed on those, but I'm not seeing that. The only links that Zotero saves to the URL field are taken from the RIS files provided by Gale (so what users would download when using citation tools --> Export to --> Reference Manager) and they do not contain `&sid=googlescholar -- I've just tested this to verify and this makes sense as the translator is written to mimic the behavior of a user manually exporting to RIS. Could you specify where you're seeing the behavior you describe? |
jimmiazek commentedMar 12, 2019
New Authorized Gale Cengage Zotero Support File.
Please review and update this file. This update authorizes support for gale.com, galegroup.com, and supported gale development servers (ggtest.com).
Jim Miazek
Software Engineer IV
Gale Cengage Learning
jim.miazek@cengage.com