Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GaleGDC.js #1908

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jimmiazek
Copy link

jimmiazek commented Mar 12, 2019

New Authorized Gale Cengage Zotero Support File.

Please review and update this file. This update authorizes support for gale.com, galegroup.com, and supported gale development servers (ggtest.com).

Jim Miazek
Software Engineer IV
Gale Cengage Learning
jim.miazek@cengage.com

Update GaleGDC.js
New Authorized Gale Cengage Zotero Support File.
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Mar 12, 2019

Could you specify for which Gale databases this will work and/or has been tested? We're seeing very different page structures for different Gale databases and have two well-working translators covering most (all?) of those except GDC (which the previous version of this one covered.)

@jimmiazek

This comment has been minimized.

Copy link
Author

jimmiazek commented Mar 12, 2019

@jimmiazek

This comment has been minimized.

Copy link
Author

jimmiazek commented Mar 13, 2019

So what next? Your eslintrc rules are different. No problem, we can change. But most of these errors have to do with the JSON object that is declared before the code.

What do we do now?

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Mar 13, 2019

don't worry about the automated errors for now. I'll need to review the code & performance first

@jimmiazek

This comment has been minimized.

Copy link
Author

jimmiazek commented Mar 13, 2019

As mentioned earlier, we would like the other translators taken down. The links used are not correct and need to be customized to our user's login.

Our products will be under going a migration to new platforms with different domain including in some cases, new path and URI. We would like to ensure that the experience will work for all of our products, not just a certain few. That is why, as a company, we intend to support Zotero web translation, ourselves.

If you wish to speak in conference then please contact me at jim.miazek@cengage.com.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Mar 13, 2019

I'm absolutely happy to take the existing translators down provided yours produce equivalent or higher-quality import, yes. (Not sure what links you're referring to, though? Just the test cases?)

@jimmiazek

This comment has been minimized.

Copy link
Author

jimmiazek commented Mar 13, 2019

The problem is that the targets (in these translators) from these other connecters are matching our production servers which we host 170 database applications. The URLs used and are saved in Zotero are incorrect -- They contain "&sid=googlescholar" in the URL. These links need to be removed ASAP! Therefore these translators need to be removed ASAP!

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Mar 13, 2019

I assume you don't blindly accept other people's code into your production platform and neither does Zotero. We'll review this as speedily as possible, but we also won't rush code review cc @dstillman .

As I say above, I'll look at your code and see how it performs and am happy to accept it provided it provides the same quality and coverage of import.

If there are severe problems with Zotero's Gale import, we will obviously act with the appropriate speed on those, but I'm not seeing that. The only links that Zotero saves to the URL field are taken from the RIS files provided by Gale (so what users would download when using citation tools --> Export to --> Reference Manager) and they do not contain `&sid=googlescholar -- I've just tested this to verify and this makes sense as the translator is written to mimic the behavior of a user manually exporting to RIS. Could you specify where you're seeing the behavior you describe?
They only way I can see that &sid=googlescholar would make it into Zotero is if people download Gale citations directly from google scholar, not accessing your database at all, and in that case, of course, your translators wouldn't change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.