Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Gelman Library Floor plan - Issue 99 #100

Merged
merged 4 commits into from Mar 13, 2019

Conversation

Projects
2 participants
@SamFritz
Copy link
Member

SamFritz commented Mar 13, 2019

This PR addresses issue 99: which adds in image of Gelman library floor plan to show where the NCLC room is located.

Commits on the PR also:

  • re-format map and floor plan into table form for easier and condensed layout
  • png floor plan is clickable image
  • document clean up of once information is "out of use" it will move down, for know there is no reason to have duplication information.

Tested and successfully displays via safari (Version 12.0.3 (13606.4.5.3.1)) + Google Chrome (Version 68.0.3440.106 (Official Build) (64-bit)).

@ianmilligan1 let me know if you think any other formatting would be helpful.

@SamFritz SamFritz self-assigned this Mar 13, 2019

@SamFritz SamFritz requested a review from ianmilligan1 Mar 13, 2019

@ianmilligan1 ianmilligan1 added this to In Progress in GWU via automation Mar 13, 2019

@ianmilligan1
Copy link
Member

ianmilligan1 left a comment

See comment - just a suggestion around stacking the directions + floor plan rather than having them side by side in a table.

@@ -47,13 +47,11 @@ Thank you for your interest in the Archives Unleashed Datathon, submissions for

## Venue

George Washington University - Foggy Bottom Campus
| Directions | Gelman Library Floor Plans |

This comment has been minimized.

@ianmilligan1

ianmilligan1 Mar 13, 2019

Member

I think we should put the floor plans below the directions - maybe as a new table? The tables are a bit funky on responsive mode, so if somebody is quickly checking directions on their phone they'll see this:

Screen Shot 2019-03-13 at 3 17 08 PM

I suspect the floor plan will be most useful when somebody is on their phone trying to see where to go.

@ianmilligan1 ianmilligan1 merged commit 1aaeb19 into master Mar 13, 2019

GWU automation moved this from In Progress to Complete Mar 13, 2019

@ianmilligan1 ianmilligan1 deleted the issue-99 branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.