Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding missing character #20

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@emitrokhina
Copy link

emitrokhina commented Mar 13, 2019

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files          19       19           
  Lines         784      784           
=======================================
  Hits          700      700           
  Misses         84       84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0ec3a...caae5b4. Read the comment docs.

@leeper

This comment has been minimized.

Copy link
Owner

leeper commented Mar 13, 2019

This looks great. Thank you! Want to try running devtools::document() (or the RStudio commands described here) to build the documentation files? Once you do that, you can update the PR simply by pushing an update to your repository with those changes and that will be reflected here.

@leeper

This comment has been minimized.

Copy link
Owner

leeper commented Mar 13, 2019

Oh, and one other thing: it's good to mention the issue you're addressing in your git commit message, like:

adding missing character (closes #19)

That links this PR to that issue (both to let others know you're working on the issue and when I merge this PR, it will lead github to close that issue as complete automatically).

@leeper leeper added the enhancement label Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.