Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upadding missing character #20
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 19 19
Lines 784 784
=======================================
Hits 700 700
Misses 84 84 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This looks great. Thank you! Want to try running |
This comment has been minimized.
This comment has been minimized.
Oh, and one other thing: it's good to mention the issue you're addressing in your git commit message, like:
That links this PR to that issue (both to let others know you're working on the issue and when I merge this PR, it will lead github to close that issue as complete automatically). |
emitrokhina commentedMar 13, 2019
Please ensure the following before submitting a PR:
/R
not/man
and rundevtools::document()
to update documentation/tests
for any new functionality or bug fixR CMD check
runs without error before submitting the PR