Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAs a superuser, I would like a button to delete a user #4475
Comments
This comment has been minimized.
This comment has been minimized.
@laertecchla thanks for your feedback. For more context, @laertecchla and I were discussing the lack of a delete button on the "Manage Users" table in the dashboard I explained how to use |
This comment has been minimized.
This comment has been minimized.
As of now, as far as I can tell, the "Manage Users" page is actually just a list of users, and the only options available are the "Superuser" check box or "Remove All Roles". Do I understand correctly that any other management task is to be performed using |
This comment has been minimized.
This comment has been minimized.
@ajs6f good point. What other users managements tasks would you like to perform? |
This comment has been minimized.
This comment has been minimized.
I don't think they are unusual: Add/remove users, edit user metadata, issue password resets, add/remove roles, etc. |
This comment has been minimized.
This comment has been minimized.
As a side note, this is not just a convenience for me: I will be filing a bug in a few minutes that in our new evaluation installlation, new users (who sign themselves) up are created with no roles at all (I checked the db to be sure) and the UI is failing for them. I would like to quickly correct that situation for at least some users so that we can go on with our evaluation of the product, but it now seems that I will have to learn something of the Dataverse API to do it. I.e. this issue is preventing us from even evaluating Dataverse as a product. |
This comment has been minimized.
This comment has been minimized.
@ajs6f I'm sorry to hear about your trouble. Please do open that issue because I'm confused about why the UI is failing for new users (not having any roles is normal). #2029 was closed a while ago for security reasons. It has a title of "SuperUser: grant ability to see and edit all user info and reset passwords (like we did in 3.6 as network admins)" and it referred to the previous generation of Dataverse, which was DVN 3. I'm not sure what the current thinking is. @laertecchla do you and @ajs6f want the same things? Originally, you only wanted a delete button. I'm asking because we try to work in small chunks. The smaller the change, the faster it moves across our kanban board at https://waffle.io/IQSS/dataverse |
This comment has been minimized.
This comment has been minimized.
I didn't mean to hijack this ticket. If you want to split up my larger request for different user management functions and leave this one as delete only, that's fine with me. |
This comment has been minimized.
This comment has been minimized.
@ajs6f the conversation is way more valuable to me than our process, but yes, we might end up breaking the work into smaller issues, as needed. First I want to understand what the needs are. I do agree that the things you're asking for are very common in the type of software Dataverse is. I tend to think of it as "enterprise" software but maybe there's a better term for it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Heh. Ok, thanks, @laertecchla @ajs6f if you would create a new issue about the user management functions you're interested in, it would be most appreciated! |
This comment has been minimized.
This comment has been minimized.
I'd rather take the conversation over to #4515 for now, for reasons that will become apparent in my next comment to that ticket. |
This comment has been minimized.
This comment has been minimized.
@laertecchla are you still interested in a delete button for users? You might be interested in the " User accounts - should users be able to request deletion of their accounts?" thread at https://groups.google.com/d/msg/dataverse-community/nGVCS5L3vPk/GSjkx1-xCAAJ |
pdurbin
added
Status: Still Interested?
User Role: Superuser
labels
Jul 13, 2018
laulandn
referenced this issue
Jul 13, 2018
Open
Having some trouble when a user tries logging in using both Shib AND OAuth...I think... #4769
This comment has been minimized.
This comment has been minimized.
Hi Philip.
Thank you.
Laerte.
De: "Philip Durbin" <notifications@github.com>
Para: "IQSS/dataverse" <dataverse@noreply.github.com>
Cc: "laertecchla" <laerte@cchla.ufpb.br>, "Mention" <mention@noreply.github.com>
Enviadas: Sexta-feira, 13 de julho de 2018 0:14:03
Assunto: Re: [IQSS/dataverse] Admin Manage Users (#4475)
[ https://github.com/laertecchla | @laertecchla ] are you still interested in a delete button for users? You might be interested in the " User accounts - should users be able to request deletion of their accounts?" thread at [ https://groups.google.com/d/msg/dataverse-community/nGVCS5L3vPk/GSjkx1-xCAAJ | https://groups.google.com/d/msg/dataverse-community/nGVCS5L3vPk/GSjkx1-xCAAJ ]
—
You are receiving this because you were mentioned.
Reply to this email directly, [ #4475 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AjJ--2E2C-GDt-wlcX26oxhbFoLCCgMcks5uGBB7gaJpZM4ST440 | mute the thread ] .
|
This comment has been minimized.
This comment has been minimized.
@laertecchla you're welcome. Are you still interested in this issue? If so, can you please give it a more specific title? |
This comment has been minimized.
This comment has been minimized.
Philip,
I am still interested in this issue for sure. But, at the moment, only on technical aspect once I have been created some users for test in dataverse.ufpb.br and I would like to exclude some of them. I've been reading Janet McDougall post as well as your post about delete a user and I've been concluded that we have got an unresolved question...
So, a more specific title would be: how can I delete a user created for tests?
Thanks.
Laerte.
De: "Philip Durbin" <notifications@github.com>
Para: "IQSS/dataverse" <dataverse@noreply.github.com>
Cc: "laertecchla" <laerte@cchla.ufpb.br>, "Mention" <mention@noreply.github.com>
Enviadas: Quarta-feira, 18 de julho de 2018 12:50:23
Assunto: Re: [IQSS/dataverse] Admin Manage Users (#4475)
[ https://github.com/laertecchla | @laertecchla ] you're welcome. Are you still interested in this issue? If so, can you please give it a more specific title?
—
You are receiving this because you were mentioned.
Reply to this email directly, [ #4475 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AjJ--32rn0pqW0d968sjnlgX0GDYFWKwks5uH1k_gaJpZM4ST440 | mute the thread ] .
|
pdurbin
changed the title
Admin Manage Users
how can I delete a user created for tests?
Jul 18, 2018
This comment has been minimized.
This comment has been minimized.
@laertecchla the new title sounds fine to me so I changed it. It reminds me of #1929 and you might find some useful information in there. If not, please let us know how we can help! |
This comment has been minimized.
This comment has been minimized.
Peter,
I've read #1929 and your answer to @amberleahey drawn my attention. In that case, how is it possible to remove the user "sparrow", for instance?
Laerte.
De: "Philip Durbin" <notifications@github.com>
Para: "IQSS/dataverse" <dataverse@noreply.github.com>
Cc: "laertecchla" <laerte@cchla.ufpb.br>, "Mention" <mention@noreply.github.com>
Enviadas: Quarta-feira, 18 de julho de 2018 14:09:22
Assunto: Re: [IQSS/dataverse] how can I delete a user created for tests? (#4475)
[ https://github.com/laertecchla | @laertecchla ] the new title sounds fine to me so I changed it. It reminds me of [ #1929 | #1929 ] and you might find some useful information in there. If not, please let us know how we can help!
—
You are receiving this because you were mentioned.
Reply to this email directly, [ #4475 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AjJ--yIqLHrlxGb_XsIxnAS2MxFrzPxqks5uH2vCgaJpZM4ST440 | mute the thread ] .
|
This comment has been minimized.
This comment has been minimized.
@laertecchla it's Phil not Peter but that's ok. Like this:
|
This comment has been minimized.
This comment has been minimized.
Sorry, Phil!
I have two more doubts:
1. Why dataverse hasn't got a button to remove a user like "sparrow"?
2. If sparrow had got datasets, the comand [curl -X DELETE http...] could remove the datasets as well?
Thanks.
Laerte.
De: "Philip Durbin" <notifications@github.com>
Para: "IQSS/dataverse" <dataverse@noreply.github.com>
Cc: "laertecchla" <laerte@cchla.ufpb.br>, "Mention" <mention@noreply.github.com>
Enviadas: Sexta-feira, 20 de julho de 2018 11:03:22
Assunto: Re: [IQSS/dataverse] how can I delete a user created for tests? (#4475)
[ https://github.com/laertecchla | @laertecchla ] it's Phil not Peter but that's ok. \uD83D\uDE04
Like this:
curl -X DELETE http://localhost:8080/api/admin/authenticatedUsers/sparrow
—
You are receiving this because you were mentioned.
Reply to this email directly, [ #4475 (comment) | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AjJ--5Hvd2i0X0HYmoedd-QY6XOakfoDks5uIeMqgaJpZM4ST440 | mute the thread ] .
|
This comment has been minimized.
This comment has been minimized.
@laertecchla as #2419 says, "Removing the account altogether would create a hole in existing datasets." It sounds a little scary to me to give superusers a button to click that deletes a bunch of datasets. What if the datasets have been published and have a real DOI and that DOI has been cited? We use a special word for deleting published datasets: destroy. And we don't offer a button for datasets to be destroyed. You have to use the API (but it's not currently documented, which is what #2593 is about). Is this helping? Please keep the questions coming? We should be figuring out what the "definition of done" is for this issue. |
pdurbin
added
the
Feature: Account & User Info
label
Oct 13, 2018
pdurbin
referenced this issue
Nov 6, 2018
Open
can't delete user if entry in passwordresetdata #5281
This comment has been minimized.
This comment has been minimized.
adam3smith
commented
Mar 14, 2019
This comment has been minimized.
This comment has been minimized.
@adam3smith that "anonymous user" concept is interesting. I will say that @sekmiller @matthew-a-dunlap @scolapasta and I have been thinking about users a lot lately because there's been a lot of discussion around pull request #5626 which has to do with merging accounts (#5514). A lot of the same problems apply. I'm curious what your experience with deleting users via API has been. Does it usually work? Do you do some checking of related tables before you attempt it? Maybe the next "small chunk" would be to improve the delete user API to do more pre-flight checking of related tables. You can see a list of related tables in the pull request above. |
This comment has been minimized.
This comment has been minimized.
adam3smith
commented
Mar 14, 2019
We don't do it a lot and we (i.e. @qqmyers ) do check related tables. Adding preflight checks to the API would definitely help (and be a useful step/precondition towards an eventual UI solution) and could then likely be expanded to include methods for deletion and eventually a button if that's not considered too risky. Thanks! |
This comment has been minimized.
This comment has been minimized.
@adam3smith thanks. I think of #1929 as the issue for adding pre-flight checks since this issue (#4475) feel like it's more about adding a GUI. @laertecchla is that right? You'd like a button in the GUI? @ajs6f are you still with us? |
This comment has been minimized.
This comment has been minimized.
adam3smith
commented
Mar 14, 2019
Just to be clear, I also want a button in the UI, I'll just also take related improvements ;) |
This comment has been minimized.
This comment has been minimized.
@adam3smith sure. Mostly I'm just wondering if we should change the title of this issue to say something about a GUI. You are, of course, welcome to create new issues. It's easier to discuss and estimate issues where the scope is clear. Often we'll try to build the API first in one issue. Then we'll try to add a GUI later in a later issue. Of course, when a pull request from the community comes along, we don't have to spend as much time discussing scope. The scope in that case is whatever is implemented in the pull request. All we have to think about is, "Do we want this or not?" More often than not, we want it. Free code! |
This comment has been minimized.
This comment has been minimized.
@adam3smith @pdurbin Yes, the reason we have been wary to add the current API to the UI (for deletable users) or add to documentation as a fully supported API is the fact that it does not do this pre flight stuff, nor does it handle deleting roleassignments. So, I think the steps could be:
(*) we have considered doing something similar to Drupal to anonymize users downloads, but didn't want to do that with content that was created as it. For downloads it can also be tricky - for example, with green data tags, we require a user is logged in, so that they can be contacted in the event that the data needs to be deleted. By anonymizing the download, we (obviously) can't contact them anymore. |
This comment has been minimized.
This comment has been minimized.
@pdurbin, I am a little bit lost here, but I've captured a print from users/groups section and attached it. So, do you mean something about the "removed assigned role" button? |
This comment has been minimized.
This comment has been minimized.
@laertecchla hi! On that screenshot, do you want a "Delete user" button? |
This comment has been minimized.
This comment has been minimized.
Hi, @pdurbin . Yes, I would like to have this button. I would like to exclude a user as I can do it in DSpace... |
pdurbin
changed the title
how can I delete a user created for tests?
As a superuser, I would like a button to delete a user
Mar 14, 2019
This comment has been minimized.
This comment has been minimized.
@laertecchla ok, I just updated the title of this issue. If you think a different title would be better, please go ahead and change it. Thanks! |
laertecchla commentedFeb 26, 2018
•
edited by pdurbin
Hi, I would like to have a delete button on the Manage Users page in order to exclude an account. Is it possible?