Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upShould we hide the "Analyze Collection" button if collection_analyzed returns true? #136
Comments
ruebot
added
the
question
label
Jun 6, 2018
ruebot
assigned
ianmilligan1 and
SamFritz
Jun 6, 2018
This comment has been minimized.
This comment has been minimized.
I was just thinking about this as I was working. Maybe switch to a "re-analyse" button. Also, a back button or bread crumbs would be nice too. As I am working, I keep looking for it. |
This comment has been minimized.
This comment has been minimized.
Yes I think so. Remind me... this is the workflow for "updating" a collection that's had an additional crawl:
Maybe if there's a collection analyzed we could change the text to read "Update Collection"? |
This comment has been minimized.
This comment has been minimized.
This is a good question! My initial reaction is yes. There have been times when I've selected a handful of collections to analyze, but then forget which ones I've already done, so I know I've hit analyze multiple times on a single collection. Hidding the button (if returns true) would certainly help with reducing the number of time a user would click unnecessarily. I like @ianmilligan1 suggestion of an "Update Collection" text if possible |
This comment has been minimized.
This comment has been minimized.
From the technovation mentoring stuff, I learned a bit about doing some quick UI using paper screen shots. I think it might be useful to run some brief user tests with some grad students and other history-friendly folk who aren’t familiar with what we are doing. |
This comment has been minimized.
This comment has been minimized.
@ianmilligan1 "Update Collection" would just run the same job again if there was no "re-seed" update. That's why I was thinking of just hiding it for now because "Update" would be misleading IMO. |
This comment has been minimized.
This comment has been minimized.
@ruebot Agreed.. and if they ran the "re-seed" update, would the "Analyze Collection" button reappear? |
This comment has been minimized.
This comment has been minimized.
@ianmilligan1 we theoretically could. Off the top of my head, we'd just have to start keeping track of the number of times the seed jobs, and analyze ran for a user, and align them. Probably a better way to do it. But, that's not an easy implementation off the top of my head. |
This comment has been minimized.
This comment has been minimized.
Now that we have the If y'all are cool with it, I can proceed with hiding the button if |
This comment has been minimized.
This comment has been minimized.
Yes, let's do that! |
This comment has been minimized.
This comment has been minimized.
sounds good! |
ruebot commentedJun 6, 2018
See also: #120, #135 dc6a9ac#diff-541f2644347a86b9ecab57feb1c74340