Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we hide the "Analyze Collection" button if collection_analyzed returns true? #136

Closed
ruebot opened this Issue Jun 6, 2018 · 10 comments

Comments

Projects
None yet
4 participants
@ruebot
Copy link
Member

ruebot commented Jun 6, 2018

@greebie

This comment has been minimized.

Copy link
Contributor

greebie commented Jun 6, 2018

I was just thinking about this as I was working. Maybe switch to a "re-analyse" button.

Also, a back button or bread crumbs would be nice too. As I am working, I keep looking for it.

@ianmilligan1

This comment has been minimized.

Copy link
Member

ianmilligan1 commented Jun 6, 2018

Yes I think so.

Remind me... this is the workflow for "updating" a collection that's had an additional crawl:

  • i.e. user analyzes collection and is happy;
  • additional crawl happens at Archive-It;
  • they update their archive-it collections on the user page;
  • and then goes back to collection and hits "Analyze Collection" to add in the extra crawl.

Maybe if there's a collection analyzed we could change the text to read "Update Collection"?

@SamFritz

This comment has been minimized.

Copy link
Member

SamFritz commented Jun 6, 2018

This is a good question! My initial reaction is yes.

There have been times when I've selected a handful of collections to analyze, but then forget which ones I've already done, so I know I've hit analyze multiple times on a single collection.

Hidding the button (if returns true) would certainly help with reducing the number of time a user would click unnecessarily.

I like @ianmilligan1 suggestion of an "Update Collection" text if possible

@greebie

This comment has been minimized.

Copy link
Contributor

greebie commented Jun 6, 2018

From the technovation mentoring stuff, I learned a bit about doing some quick UI using paper screen shots. I think it might be useful to run some brief user tests with some grad students and other history-friendly folk who aren’t familiar with what we are doing.

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Jun 6, 2018

@ianmilligan1 "Update Collection" would just run the same job again if there was no "re-seed" update. That's why I was thinking of just hiding it for now because "Update" would be misleading IMO.

@ianmilligan1

This comment has been minimized.

Copy link
Member

ianmilligan1 commented Jun 6, 2018

@ruebot Agreed.. and if they ran the "re-seed" update, would the "Analyze Collection" button reappear?

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Jun 6, 2018

@ianmilligan1 we theoretically could. Off the top of my head, we'd just have to start keeping track of the number of times the seed jobs, and analyze ran for a user, and align them. Probably a better way to do it. But, that's not an easy implementation off the top of my head.

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 6, 2019

Now that we have the collection_queued helper with 6da2791, it's trivial to hide the button. That way we won't run into folk clicking it multiple times, and queuing up the same collection multiple times in a row for analysis.

If y'all are cool with it, I can proceed with hiding the button if collection_queued meets a criteria.

@ianmilligan1

This comment has been minimized.

Copy link
Member

ianmilligan1 commented Mar 6, 2019

Yes, let's do that!

@SamFritz

This comment has been minimized.

Copy link
Member

SamFritz commented Mar 6, 2019

sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.