Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ggplot #12

Merged
merged 5 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@ruebot
Copy link
Member

ruebot commented Mar 2, 2019

DO NOT MERGE UNTIL AFTER #11 IS MERGED

Tested on default dataset and mounted data, all cells worked.

ruebot added some commits Mar 1, 2019

Setup Docker for notebooks
- Add Dockerfile,
- Add required nltk data
- Add instructions in README
Resolve #9
- Rename notebook files
  - Create example notebook with existing data
  - Create notebook with empty collection id, and help text
- Update language in README and notebooks
- Tweak Dockerfile

@ruebot ruebot requested review from greebie and ianmilligan1 Mar 2, 2019

@ruebot ruebot referenced this pull request Mar 2, 2019

Closed

Test Notebooks in Other OSs #7

@ruebot ruebot force-pushed the ggplot branch from 6bd0aa0 to 00a933b Mar 3, 2019

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 3, 2019

I tweaked the README, and made sure the auk-example-notebook was fully executed. Added it to this PR since the other two open ones are previous to this one; don't want to end up with merge conflicts 😱

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 3, 2019

Even more fun, it all works with Binder when we add the Dockerfile 🎉

(tweak the User Configuration settings, and run all again)

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 3, 2019

...once everything is merged, we can add the badge to the example notebook.

Binder

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Mar 3, 2019

lgtm once conflicts are resolved.

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 3, 2019

@greebie please wait until @ianmilligan1 reviews and tests as well. I'v configured this repo to have at least two reviewers review before a PR is merged now.

@ruebot

This comment has been minimized.

Copy link
Member Author

ruebot commented Mar 3, 2019

Commit message, when time to merge should read:

Title: Remove ggplot, and have auk-notebook-example fully executed. (#12)
Body:

- Remove ggplot
- Set auk-notebook-example to be fully executed
- Additional README tweaks

screenshot from 2019-03-03 16-17-06

@ianmilligan1
Copy link
Member

ianmilligan1 left a comment

Looks good to me - I've tested, ggplot warnings are gone, and all cells ran and executed properly. Great stuff.

@greebie

greebie approved these changes Mar 4, 2019

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Mar 4, 2019

Works good for me too.

@ianmilligan1 ianmilligan1 merged commit c1b1f7c into master Mar 4, 2019

1 check passed

ci/dockercloud Your tests passed in Docker Cloud
Details

@ianmilligan1 ianmilligan1 deleted the ggplot branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.