Skip to content

/auk-notebooks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors when graph files are not available: #40

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Reviewers

@greebie greebie

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @greebie @ianmilligan1
@ruebot
Copy link
Member

ruebot commented Mar 13, 2019

  • Wrap three cells in try/catch statements
  • The first of those statements explicitly catches OSError for FileNotFoundError
  • The last two catch any error
@ruebot
Catch errors when graph files are not available: 
- Wrap three cells in try/catch statements
- The first of those statements explicitly catches OSError for FileNotFoundError
- The last two catch any error
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
bc1f1fd

@ruebot ruebot requested review from greebie and ianmilligan1 Mar 13, 2019

@greebie greebie referenced this pull request Mar 14, 2019

Closed

Include functions for testing existence of derivatives. #10 #37

@greebie

greebie approved these changes Mar 14, 2019
View changes

Copy link
Collaborator

greebie left a comment

lgtm.
@ianmilligan1

ianmilligan1 approved these changes Mar 14, 2019
View changes

Copy link
Member

ianmilligan1 left a comment

Works well - tested w/ all files and then without, error messages threw as expected. Thanks to both @ruebot and @greebie for tackling this issue/reviewing code/etc.

@ianmilligan1 ianmilligan1 merged commit aed4e11 into archivesunleashed:master Mar 14, 2019
1 check passed

1 check passed

ci/dockercloud Your tests passed in Docker Cloud
Details

@ruebot ruebot deleted the ruebot:issue-10-otro branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.