New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: DmpBbo: A versatile Python/C++ library for Function Approximation, Dynamical Movement Primitives, and Black-Box Optimization #1205

Closed
whedon opened this Issue Jan 27, 2019 · 29 comments

Comments

Projects
None yet
6 participants
@whedon
Copy link
Collaborator

whedon commented Jan 27, 2019

Submitting author: @graiola (Gennaro Raiola)
Repository: https://github.com/stulp/dmpbbo
Version: v0.7-beta
Editor: @danielskatz
Reviewers: @studywolf, @jenskober

Author instructions

Thanks for submitting your paper to JOSS @graiola. The JOSS editor @danielskatz, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@graiola if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 27, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @danielskatz it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@danielskatz) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 27, 2019

Attempting PDF compilation. Reticulating splines etc...
@arfon

This comment has been minimized.

Copy link
Member

arfon commented Jan 27, 2019

👋 @danielskatz - the submitting author suggested you as the handing editor.

@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 27, 2019

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 27, 2019

👋 @graiola - Please help by looking at this list of potential reviewers and identify individuals who might be able to review your submission (please start at the bottom of the list). Also, please suggest individuals who might be good reviewers but are not on this list, ideally by mentioning their GitHub handles here, but if not, just by name.

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 27, 2019

Also, note a couple of issues in the paper - a couple of references appear as ????s, indicating that the text in {}s in the .md paper didn't match an entry in the .bib file, and the second reference has some case problems in the proceedings (booktitle) name. In addition, that reference should likely have a DOI.
After you make changes in the .md or .bib files, type @whedon generate pdf as the first line in a new comment here to rebuild the PDF, then check it.

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 27, 2019

@whedon check references

@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 27, 2019

Attempting to check references for missing DOIs
@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 27, 2019

The following potential issues were found with your references:

  • Learning Variable Impedance Control may be missing DOI: https://doi.org/10.1177/0278364911402527

  • Dynamical Movement Primitives: Learning Attractor Models for Motor Behaviors may be missing DOI: https://doi.org/10.1162/neco_a_00393

  • Joining Movement Sequences: Modified Dynamic Movement Primitives for Robotics Applications Exemplified on Handwriting may be missing DOI: https://doi.org/10.1109/tro.2011.2163863

  • Learning parametric dynamic movement primitives from multiple demonstrations may be missing DOI: https://doi.org/10.1016/j.neunet.2011.02.004

  • Many regression algorithms, one unified model – A review may be missing DOI: https://doi.org/10.1016/j.neunet.2015.05.005

  • Robot Skill Learning: From Reinforcement Learning to Evolution Strategies may be missing DOI: https://doi.org/10.2478/pjbr-2013-0003

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 27, 2019

👋 @graiola - please see the DOI issues, and fix them while fixing the other paper issue - thanks!

@openjournals openjournals deleted a comment from giraola Jan 27, 2019

@graiola

This comment has been minimized.

Copy link

graiola commented Jan 29, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 29, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 29, 2019

@graiola

This comment has been minimized.

Copy link

graiola commented Jan 29, 2019

wave @graiola - Please help by looking at this list of potential reviewers and identify individuals who might be able to review your submission (please start at the bottom of the list). Also, please suggest individuals who might be good reviewers but are not on this list, ideally by mentioning their GitHub handles here, but if not, just by name.

To start I suggest as reviewer:

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 29, 2019

Thanks - I ideally want two reviewers, so more suggestions are also welcome

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 29, 2019

👋 @studywolf - would you be willing to review this submission to JOSS?

@studywolf

This comment has been minimized.

Copy link
Collaborator

studywolf commented Jan 29, 2019

Hello! Looks very interesting, I'd be happy to review. One possible issue is that I am just about to take off for a couple weeks of travelling and probably won't have time before I go. What's the timeline here?

@graiola

This comment has been minimized.

Copy link

graiola commented Jan 30, 2019

@danielskatz I would suggest also Jens Kober as reviewer http://www.jenskober.de/code.htm
But I don't think he has a github account.

Thanks @studywolf

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 30, 2019

@studywolf - We can wait a little while for you - if you could start in a couple of weeks, that will work.

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 30, 2019

@whedon assign @studywolf as reviewer

@whedon whedon assigned danielskatz and unassigned danielskatz Jan 30, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Jan 30, 2019

OK, the reviewer is @studywolf

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Jan 30, 2019

I've emailed Jens - @graiola, if you have other suggestions, please let me know

@graiola

This comment has been minimized.

Copy link

graiola commented Jan 31, 2019

Manuel C. Lopes https://github.com/maclopes

@jenskober

This comment has been minimized.

Copy link
Collaborator

jenskober commented Feb 1, 2019

@graiola : @danielskatz contacted me, I actually have a github account (but no public repository).
I'd be happy to review the submission but will need a similar extension as @studywolf

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Feb 1, 2019

@whedon add @jenskober as reviewer

@whedon whedon assigned danielskatz and studywolf and unassigned danielskatz Feb 1, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Feb 1, 2019

OK, @jenskober is now a reviewer

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Feb 1, 2019

@whedon start review

@whedon

This comment has been minimized.

Copy link
Collaborator

whedon commented Feb 1, 2019

OK, I've started the review over in #1225. Feel free to close this issue now!

@danielskatz

This comment has been minimized.

Copy link
Collaborator

danielskatz commented Feb 1, 2019

Thanks @jenskober and @studywolf - let's move to #1225

@danielskatz danielskatz closed this Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment