Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: uJVM: Lightweight Java Virtual Machine for embedded systems #1338
Comments
whedon
assigned
gkthiruvathukal
Mar 20, 2019
whedon
added
the
review
label
Mar 20, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @morganericsson, it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
whedon
referenced this issue
Mar 20, 2019
Closed
[PRE REVIEW]: uJVM: Lightweight Java Virtual Machine for embedded systems #1268
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @omoliavko, should |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Mar 20, 2019
Hi @hainesr, I could add him to authors list, but he contributed to S/W, not the paper itself, so I'm not sure if it would be correct. |
This comment has been minimized.
This comment has been minimized.
The software is the important contribution here, so I think he should be added. The paper is of secondary importance where authorship is concerned. I'll tag in @gkthiruvathukal for an adjudication, though... |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Mar 20, 2019
I concur with @hainesr. I would think that one of the main goals of JOSS is to ensure that those who contribute substantially to the development of research software are recognized for their contributions. |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Mar 20, 2019
Ok, I'll update the author list |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Mar 20, 2019
Added Vitalii Petrychenko (vpetrychenko) to author list |
This comment has been minimized.
This comment has been minimized.
@whedon commands |
This comment has been minimized.
This comment has been minimized.
Here are some things you can ask me to do:
|
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tdrozdovsky
commented
Mar 22, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @omoliavko, I had some issues building this project with my setup. I have JDK 11 as my default java, but setting |
This comment has been minimized.
This comment has been minimized.
tdrozdovsky
commented
Mar 25, 2019
•
Hi @hainesr, Great job! I've merged your pull request. We will add a description "how to set JAVA_HOME for Java " |
This comment has been minimized.
This comment has been minimized.
tdrozdovsky
commented
Mar 25, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@arfon I've had some issues with the software. Since this is my first review for JOSS, I am unsure where/how to voice my concerns, but I'll do it here and then we can edit if it is the wrong place.
Based on this, I am not sure if the submission fulfills "The software should be feature complete" (and "either enables some new research challenges to be addressed or makes addressing research challenges significantly better" but I guess this depends on the target audience). (so, checkmarks are in some sense correct according to my current understanding of the software) |
This comment has been minimized.
This comment has been minimized.
@morganericsson this is valid feedback to mention here—you are totally allowed (expected, even) to not check something off that you don't feel the software satisfies. This is the place for such conversations between you, the authors, and the editors to get the submission to the acceptance point. |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 2, 2019
•
@morganericsson Thanks for the valuable feedback, we'll improve the documentation as soon as feasible. Now answers to your specific comments:
|
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 2, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 2, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 2, 2019
•
@hainesr @morganericsson We've added expected audience for uJVM project to paper |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 2, 2019
@hainesr @morganericsson Javadoc documentation generation is added to uJVM to view info on supported Java classes; updated README.md to reflect this and added uJVM_functionality_description.md file to docs folder. |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 3, 2019
•
@hainesr @morganericsson A guide on creating apps for uJVM was added - please see docs/java_app_creating_guide.md file. We'd be grateful for your opinion on it. |
This comment has been minimized.
This comment has been minimized.
I've reviewed the added files and the updated paper, and updated my review checklist accordingly. Overall, I think it's fine and all of my concerns have been addressed. The documentation, of course, should improve over time, but I think it's sufficient for now. |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 5, 2019
•
@morganericsson Thank you once again for your time, and a separate thank you for vote of confidence. If you have any suggestions on how to improve project and documentation further, please do not hesitate to contact us. |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 8, 2019
•
@arfon @kyleniemeyer Could you please explain what steps we should take now that @morganericsson has completed the checklist? |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Apr 8, 2019
@omoliavko I will await a response from @arfon or @kyleniemeyer. It looks like we are pretty close. |
This comment has been minimized.
This comment has been minimized.
I'm aware that I need to complete my checklist too. I will endeavour to do so in the next couple of days. |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Apr 8, 2019
Thanks @hainesr. We will wait for your checklist. |
This comment has been minimized.
This comment has been minimized.
I have raised a new PR to fix javadoc on setups with multiple JDKs: Samsung/uJVM#85 |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 10, 2019
@hainesr Pull Request accepted, thank you for collaboration |
This comment has been minimized.
This comment has been minimized.
My checklist is complete now @gkthiruvathukal, @arfon. I'm happy with the submission! I think a new release now needs to be tagged @omoliavko. Would you consider calling it 1.0 in line with Semantic Versioning? https://semver.org/ One minor nit-pick: in the paper itself, I think it would read better if you wrote 'software' and 'hardware' out longhand instead of using 'S/W' and 'H/W'. But this is just my personal preference and not necessarily a barrier to acceptance. |
This comment has been minimized.
This comment has been minimized.
omoliavko
commented
Apr 10, 2019
@hainesr We're also happy with our progress so far; unfortunately, we cannot tag a new release now, because we have a development plan to adhere to, and next release of uJVM shall include several features that are in development now. |
This comment has been minimized.
This comment has been minimized.
tdrozdovsky
commented
Apr 13, 2019
@arfon @kyleniemeyer @gkthiruvathukal Could you please explain what steps we should take now that @morganericsson and @hainesr have completed the checklist? |
This comment has been minimized.
This comment has been minimized.
At this point @gkthiruvathukal will give it a final look as the editor for the submission; if he decides it is ready to accept, then he'll ask you to archive the accepted version of the package and provide an associated DOI (e.g., via Zenodo). However, hold off until you get that request from him. |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Apr 14, 2019
•
@kyleniemeyer I'm on travel right now (a mix of business and pleasure). I will work on the decision in the next day or two. I'm encouraged by what I am seeing though. Thanks to all for your patience. I will try not to keep you waiting for too long. |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Apr 16, 2019
@tdrozdovsky and @omoliavko, I have gone through the checklist, and I'm ready to accept. Based on @kyleniemeyer's follow-up, can you please archive the accepted version of the package and provide an associated DOI (e.g., via Zenodo). @kyleniemeyer Just to clarify, I do not do an accept via Whedon just yet, right? |
This comment has been minimized.
This comment has been minimized.
Hi @gkthiruvathukal - rather than asking a specific AEiC, you probably should ask all of us (to get the person on duty this week) by including @openjournals/joss-eics in the comment. And in this case, no, don't do an accept yet - you can do that once these other things (version, archive) are done, or the AEiC can do it. |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Apr 16, 2019
@danielskatz Thanks for clarifying how to ask all AEICs. Somehow that was lost on me. @openjournals/joss-eics This submission is moving toward acceptance. As this is one of the first I have seen through the process, it would be good if you can take a look that all is in order. The checklists are fine and all issues seem to have been addressed in the issue thread and follow-up. I believe we just need the DOI for the accepted version of the package. |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yep, I think we're in good shape here. At this point we just need the author to create a DOI for the software and post the URL to it here. |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Apr 16, 2019
Thanks, @arfon. Will await the DOI and associated URL and process the acceptance not long thereafter. |
whedon commentedMar 20, 2019
•
edited by hainesr
Submitting author: @omoliavko (Oleksandr Moliavko)
Repository: https://github.com/Samsung/uJVM/
Version: v0.1
Editor: @gkthiruvathukal
Reviewer: @morganericsson, @hainesr
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@morganericsson & @hainesr, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @gkthiruvathukal know.
Review checklist for @morganericsson
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @hainesr
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?