Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Notebooks? #46

Closed
edsu opened this Issue Mar 23, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@edsu
Copy link

edsu commented Mar 23, 2019

Thanks for putting these excellent examples together @greebie! I wonder if it might make sense moving forward to create separate notebooks for each use case, and if there are functions or bits of code that need to be shared perhaps they could be moved into a module that they all can use?

@ruebot

This comment has been minimized.

Copy link
Member

ruebot commented Mar 23, 2019

@edsu for modules, are you thinking something like a separate repo, that's a library, and we can release on PyPi, then pull it in?

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Mar 23, 2019

I think that's what we should aim for. Maybe add that as a separate issue. Since I think it would be easier to make the library work with the current notebook and then separate after.

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Mar 23, 2019

Another idea is to invite people to submit their own notebooks?

@edsu

This comment has been minimized.

Copy link
Author

edsu commented Mar 23, 2019

Maybe the module could start here and then migrate if needed? I do like the idea of splitting up this large notebook into smaller ones so it can load in GitHub and generally be more manageable.

Like you said I think it could set a good precedent for other people to add new ones via a pull request.

@greebie

This comment has been minimized.

Copy link
Collaborator

greebie commented Apr 11, 2019

Okay now that the module is added, I'll work on this issue. I'll go with

  • Domains
  • Text
  • Networks

The domains notebook is likely to be very short. I wonder if there is anything else we can include there? Maybe dates?

@ruebot ruebot closed this in e8b0fea Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.