New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elife translator issues #1719

Closed
tmchartrand opened this Issue Aug 20, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@tmchartrand

tmchartrand commented Aug 20, 2018

The site layout for eLife seems to have changed at some point, and the regex no longer matches.
For an example url, see https://elifesciences.org/articles/16553
Simply adding "|articles" to the regex fixed the issue for me.
Full target regex:
^https?://(elife\.)?elifesciences\.org/(content/|search|category/|browse|archive|articles)

Additionally, there's some code that apparently used to clean up extra authors, but now removes all:

//clean out the authors if they're not in citation_author, so we don't import junk from elsewhere
// as on http://elifesciences.org/content/2/E00565V1
if (!ZU.xpathText(doc, '//meta[@name="citation_author"]/@content')) {
   item.creators = [];
}

I'm unable to find an example of the old scheme where this was necessary, but commenting it out fixes the import for me.

Finally, the pdf attachments are no longer found. This currently relies on the embedded metadata translator, and it seems some custom code is needed for the new layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment