New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub Med Labs update to PubMed.js #1800

Open
akinhwan opened this Issue Dec 19, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@akinhwan

akinhwan commented Dec 19, 2018

Hello Zotero translators!

A Zotero user has indicated that they are not getting the metadata properly ingested from Pub Med Labs. Pub Med Labs is the experimental site that will eventually replace PubMed. I am one of the developers on the project. This is my first time using Zotero personally, and would appreciate any an all input from the Zotero community.

Below are some of the changes I am planning to PR. but thought I'd open an issue to have any discussion/questions here.

  • update target regex so that PubMedTranslator.js fires on PubMedLabs (hereafter PML) urls

  • current PubMed.js translator looks for meta tag with name="ncbi_uidlist". However on the abstract page it contains single article IDs, while on the docsum page - multiple IDs. We have the same data in a meta tag with a different name. I could either update the PML meta or make the translator support PML meta.

  • translator.js has function getSearchResults that extracts from search results page array of tuples (article id, article title), and it is tied closely to PubMed HTML, and needs updating to support PML (in graceful manner based on data- attributes rather than CSS class names/HTML layout)

@akinhwan

This comment has been minimized.

akinhwan commented Dec 19, 2018

Attached is a document with screenshots outlining what the user's complaints were.
Zotero.docx

@adam3smith

This comment has been minimized.

Collaborator

adam3smith commented Dec 19, 2018

Thanks for being in touch!
That all sounds great to me for a PR. 1 is a no-brainer. For 2 and 3, I'd be happy for you to just include alternate logic for PML into the existing PubMed translator. I'd probably make that logic contingent on the CSS/metatags rather than on the URL so that we don't have to worry about the timing of the PubMed to PML switch and have this working continuously.

The underlying eutils API is remaining unchanged, right?

@akinhwan

This comment has been minimized.

akinhwan commented Dec 19, 2018

@adam3smith yes the underlying eutils API will remain unchanged as far as I know. will let you know if I hear otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment