Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upZotero Item Selector unchecked selections #1804
Comments
dstillman
closed this
in
19d5ca0
Jan 10, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks — fixed. The site structure changed, so the checkboxes weren't being found. Your Zotero Connector should auto-update within 24 hours, or you can update manually by clicking Update Translators in the Advanced pane of the Zotero Connector preferences. |
This comment has been minimized.
This comment has been minimized.
akinhwan
commented
Jan 15, 2019
•
|
thanks @dstillman! I saw your code, my Pull Request is still open however, so there is a merge conflict with your contribution. |
This comment has been minimized.
This comment has been minimized.
|
I'll rebase that, don't worry about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
akinhwan commentedDec 26, 2018
•
edited
As observed on Mozilla Firefox Quantum 60.4.0esr (64-bit)
When a user makes selections on the Search Results Page, then clicks on Zotero Extension to save, the Zotero Item Selector dialog window should show/remember what the user has selected on the page.
Please see https://github.com/zotero/translators/blob/master/PubMed.js#L176
Correct me if I'm wrong but either this was never the intended functionality, or it may have broken at some point. May not be a big issue, users could also just get used to the fact that they have to make their selections within the "Zotero Item Selector", which in that case I'm not sure what Line 176 is doing, because commenting it out doesn't break the getSearchResults function nor any tests.