Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: CEGO: C++11 Evolutionary Globbal Optimization #1147
Comments
whedon
assigned
jedbrown
Dec 29, 2018
whedon
added
the
review
label
Dec 29, 2018
whedon
referenced this issue
Dec 29, 2018
Closed
[PRE REVIEW]: CEGO: C++11 Evolutionary Global Optimization #1110
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @sarats, it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@sarats @sjvrijn @mmenickelly |
This comment has been minimized.
This comment has been minimized.
Hi, first time reviewing for JOSS. To clarify this process: any comments I have that prevent me from checking off something in the checklist should be raised as an issue in the CEGO repository and not here, right? And if I have multiple comments, is there a preference for separating them into multiple issues, or combining all comments into one large issue? |
This comment has been minimized.
This comment has been minimized.
Small comments, especially anything stylistic or specific to the paper, are fine here. More significant issues, especially those that should have a definite resolution, are better filed as separate issues with the CEGO repository. |
This comment has been minimized.
This comment has been minimized.
A few small comments so far @ianhbell:
|
This comment has been minimized.
This comment has been minimized.
Comments: To fix this, I would like to see:
Two smaller comments:
|
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Feb 27, 2019
To everyone, sorry for the delay in dealing with this review... @sjvrijn I will, as I have done for other projects, bump the revision to 1.0.0 once the review is complete, and at that time I will mint a DOI, and push to PyPI. Thanks for the pointer about the DOI (fixed). Didn't realize that the conference paper had a DOI. |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Feb 27, 2019
Sorry for the delay everyone... @sjvrijn Thanks for the pointer about the DOI; I fixed that, didn't know that the conference paper had a DOI. I plan to bump the version to 1.0.0 once the review is complete, mint a DOI for the release, and push to PYPI.
A1. I think so, I did something similar for ChebTools. Do you think it is too much or too little? |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Feb 27, 2019
I have set up the Travis tests (https://travis-ci.org/usnistgov/CEGO), and pushed all changes to the repo. Awaiting round number 2! |
This comment has been minimized.
This comment has been minimized.
Is this ready for the reviewers—@sarats, @sjvrijn, @mmenickelly—to take a second look? |
This comment has been minimized.
This comment has been minimized.
@ianhbell Could you add the installing of the Python interface to the Travis setup? It currently does not fail if this does not work for some reason. Also, which Python versions is it intended/tested for? |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Mar 18, 2019
I have fixed the build issues with binder and now build the Python wrapper in TravisCI as well. All's well at the moment, ready for another look-see. |
This comment has been minimized.
This comment has been minimized.
A few more remarks:
PS: the use of for i, xi in enumerate(x):
sum1 += pow(xi.as_double(), 2)/4000.0
prod1 *= cos(xi.as_double()/sqrt(i+1)) |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Apr 5, 2019
Thanks @sjvrijn -- those were all great recommendations. I have made all them and am ready for another look-see. Some comments:
|
This comment has been minimized.
This comment has been minimized.
Glad you found them useful! RE: 0., Based on https://joss.readthedocs.io/en/latest/review_criteria.html#community-guidelines, your community guidelines explicitly covers the first two (contributions and reporting issues) but not yet the third: seeking support. A quick line on what they can do in that case would complete it for me. It could e.g. be raising an issue here on Github, sending you an email, joining a chatroom, etc Other than that, I have no further comments :) |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Apr 8, 2019
Great, I added
|
This comment has been minimized.
This comment has been minimized.
@sarats and @mmenickelly, you still have a few unchecked boxes in your reviews. Can you update us on their status and whether there are remaining issues to resolve? |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Apr 22, 2019
Looks good to me! |
jedbrown
referenced this issue
Apr 22, 2019
Merged
JOSS: minor editing and bib fixes; add Jupyter and Binder citations #2
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Apr 23, 2019
Here it is: 10.5281/zenodo.2649254
Annotated tag added too
|
This comment has been minimized.
This comment has been minimized.
Thanks. Please update the author info to remove my name. |
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.2649254 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.2649254 is the archive. |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Apr 23, 2019
Hmm - where is your name listed as author? |
This comment has been minimized.
This comment has been minimized.
In the Zenodo archive; follow DOI link above or direct here: https://zenodo.org/record/2649254 |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Apr 23, 2019
Got it -- fixed
|
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#640, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@openjournals/joss-eics We're ready for you. |
jedbrown
added
the
accepted
label
Apr 23, 2019
This comment has been minimized.
This comment has been minimized.
Thanks for the reviews, @sarats, @sjvrijn, @mmenickelly, and for the editing, @jedbrown |
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
There seems to be a problem with the paper, specifically https://www.theoj.org/joss-papers/joss.01147/10.21105.joss.01147.pdf isn't there. |
This comment has been minimized.
This comment has been minimized.
It's there now?
|
This comment has been minimized.
This comment has been minimized.
really? When I try it on a wifi network and on my phone, I don't see it on either |
This comment has been minimized.
This comment has been minimized.
The DOI resolves correctly, and the landing page for the paper is fine, but the PDF of the paper is 404 for me |
This comment has been minimized.
This comment has been minimized.
ianhbell
commented
Apr 23, 2019
Link works for me! |
This comment has been minimized.
This comment has been minimized.
I can see the pdf from that link |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
weird... |
This comment has been minimized.
This comment has been minimized.
@arfon, any thoughts on this before I close the issue? I'll also try again in 2 hours from another location and see if it works there |
This comment has been minimized.
This comment has been minimized.
Now it’s working for me |
danielskatz
closed this
Apr 23, 2019
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
This comment has been minimized.
This comment has been minimized.
The PDFs are cached in Cloudflare which means that if you click the link to the PDF before GitHub pages has had a chance to build (and deploy) then you can get a 404. Your browser (and Cloudflare) can then sometimes cache the 404 response (I think). |
whedon commentedDec 29, 2018
•
edited
Submitting author: @ianhbell (Ian Bell)
Repository: https://github.com/usnistgov/CEGO
Version: v1.0.0
Editor: @jedbrown
Reviewer: @sarats, @sjvrijn, @mmenickelly
Archive: 10.5281/zenodo.2649254
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@sarats & @sjvrijn & @mmenickelly, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @jedbrown know.
Review checklist for @sarats
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @sjvrijn
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @mmenickelly
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?