Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop to version 0.68.1 #68
+1
−1
Conversation
depfu
bot
added
the
depfu
label
May 1, 2019
depfu
bot
referenced this pull request
May 1, 2019
Closed
[ruby] Upgrade rubocop to version 0.68.0 #67
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
May 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34Continue to review full report at Codecov.
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
May 1, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34Continue to review full report at Codecov.
|
ruebot
approved these changes
May 2, 2019
ruebot
merged commit 2fa3c21
into
master
May 2, 2019
depfu
bot
deleted the
depfu/update/rubocop-0.68.1
branch
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedMay 1, 2019
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
0.68.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 15 commits:
Cut 0.68.1[Fix #6738] Prevent auto-correct conflict of `Style/Next` and `Style/SafeNavigation` (#7006)Add a validation for RuboCop's config/default.yml for supported styles other than EnforcedStyleRemove pry-byebugFix `Style/BlockDelimiters` to properly check if the node is chaned when `braces_for_chaining` is set.Handle properly empty if blocks in Style/SafeNavigation (#6993)Merge pull request #7000 from koic/fix_false_positive_for_style_mixin_usageFix an incorrect auto-correct for `Style/InverseMethods`[Fix #6972] Fix a false positive for `Style/MixinUsage`[Fix #6992] Fix unknown default configuration for Layout/IndentFirstParameterRefactor with `range_type`[Fix #6996] Allow freezing result of `String#*` (#6997)Refactor cops to use matching on childrenImprove Naming/RescuedExceptionsVariableName autocorrectionFix an incorrect auto-correct for `Style/RedundantParentheses`Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands