Skip to content

/MementoEmbed

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG favicons fail to generate data URIs #139

Closed
shawnmjones opened this issue Oct 22, 2018 · 0 comments

Comments

Assignees

@shawnmjones shawnmjones

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@shawnmjones
@shawnmjones
Copy link
Collaborator

commented Oct 22, 2018

Some favicons are not ICO, but SVG. The Pillow library does not work with SVG content directly, hence MementoEmbed does not convert SVG to data URIs.

The following library may be useful for detecting SVG content: https://pypi.org/project/python-magic/.

Once an SVG is detected, it can be converted to PNG. See https://cairosvg.org.

These mementos are affected:

@shawnmjones shawnmjones added the bug label Oct 22, 2018

@shawnmjones shawnmjones self-assigned this Oct 22, 2018

@shawnmjones shawnmjones closed this in 5c2a6a4 Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.