Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSVG favicons fail to generate data URIs #139
Comments
shawnmjones
added
the
bug
label
Oct 22, 2018
shawnmjones
self-assigned this
Oct 22, 2018
shawnmjones
closed this
in
5c2a6a4
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
shawnmjones commentedOct 22, 2018
Some favicons are not ICO, but SVG. The Pillow library does not work with SVG content directly, hence MementoEmbed does not convert SVG to data URIs.
The following library may be useful for detecting SVG content: https://pypi.org/project/python-magic/.
Once an SVG is detected, it can be converted to PNG. See https://cairosvg.org.
These mementos are affected: