/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI for Advanced Publication in ACS styles #1723

Closed
adam3smith opened this Issue Oct 11, 2015 · 5 comments

Comments

Assignees
No one assigned
Labels
style-error
Projects
None yet
Milestone
No milestone
3 participants
@adam3smith @POBrien333 @rmzelle
@adam3smith

@adam3smith adam3smith added the style-error label Oct 11, 2015

@POBrien333

This comment has been minimized.

Sign in to view
Contributor

POBrien333 commented Jan 3, 2017 •
edited by rmzelle

I see there are several ACS styles which include the DOI from Sept 16. This has been dealt with therefore?
@adam3smith

This comment has been minimized.

Sign in to view
Member

adam3smith commented Jan 3, 2017

not having looked closely, I don't think so, no: the styles that do not include DOIs should have them added for items published early online. We usually test for the absence of volume and pages, i.e. <if variable="page volume" match="none"> and then print the DOI for that purpose.
@stale

This comment has been minimized.

Sign in to view

stale bot commented Dec 28, 2018

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label Dec 28, 2018

@adam3smith adam3smith referenced this issue Dec 30, 2018

Merged

Update american-chemical-society.csl #3850

@rmzelle

This comment has been minimized.

Sign in to view
Member

rmzelle commented Dec 31, 2018 •
edited

@adam3smith, I think this is already covered by the current ACS style, which prints the DOI for all items if available. See

styles/american-chemical-society.csl

Lines 265 to 268 in b55a77d

</choose>
<text variable="DOI" prefix=". https://doi.org/"/>
</layout>
</bibliography>
.

Please close this issue if you agree.

@stale stale bot removed the waiting label Dec 31, 2018

@adam3smith

This comment has been minimized.

Sign in to view
Member

adam3smith commented Jan 3, 2019

indeed, yes.

@adam3smith adam3smith closed this Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment