Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style dev assist: tests with watch #3994

Open
fbennett opened this issue Mar 17, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@fbennett
Copy link
Member

commented Mar 17, 2019

Something like this might already exist, but here goes.

I've finally gotten around to rewriting the citeproc-js test runner in Node.js. (It's been a long time coming, I know.) Looking at the work on APA at #3602, I'm thinking that some small changes to the script might help lighten development for complex styles.

The idea would be to set up a separate area in the citeproc-js repo for style folders, and add two options to the script:

  • -S to instruct the script to run tests from a particular style's folder, and
  • -w to instruct the script to watch for changes in a style file being edited.

Script would then poll for changes to the style, and rerun the tests when change is detected, to provide alerts of collateral changes that a given change might have, without keyboard/mouse back-and-forth. Kind of Zotero Style Editor on steroids/NTZ.

I've used manually run processor test fixtures here for a style project recently, and it worked quite well. Watch monitoring would lighten the process further.

Thoughts? Rotten tomatoes?

@bwiernik

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

This would be really cool. I would love to set up all of the tests for APA style.

@fbennett

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

Here you go: https://github.com/Juris-M/citeproc-test-runner#citeproc-test-runner

(Edit: Updated the link. The test runner is now a separate self-contained project, and can be installed and run without cloning the citeproc-js sources.)

@stale

This comment has been minimized.

Copy link

commented May 6, 2019

This issue hasn't seen any activity in the past 30 days. It will be automatically closed if no further activity occurs in the next two weeks.

@stale stale bot added the waiting label May 6, 2019

@stale stale bot closed this May 20, 2019

@adam3smith adam3smith reopened this May 20, 2019

@stale stale bot removed the waiting label May 20, 2019

@adam3smith

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@rmzelle not sure if we can apply Stalebot to PRs only?

@rmzelle

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@rmzelle not sure if we can apply Stalebot to PRs only?

We could: probot/stale@26a2123#diff-04c6e90faac2675aa89e2176d2eec7d8R32

@adam3smith

This comment has been minimized.

Copy link
Member

commented May 20, 2019

What do you think? I don't mind issues staying open for a long time, especially something like this. It's the PRs where the bot really helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.