Skip to content

/joss-reviews

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: stardate: Combining dating methods for better stellar ages #1460

Open
whedon opened this issue May 19, 2019 · 21 comments

Comments

Assignees

@arfon arfon

Labels
AAS Jupyter Notebook Makefile TeX pre-review
Projects
None yet
Milestone
No milestone
4 participants
@whedon @arfon @RuthAngus @danielskatz
@whedon
Copy link
Collaborator

commented May 19, 2019 •
edited

Submitting author: @RuthAngus (Ruth Angus)
Repository: https://github.com/RuthAngus/stardate
Version: v0.1.0
Editor: @arfon
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @RuthAngus. Currently, there isn't an JOSS editor assigned to your paper.

@RuthAngus if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label May 19, 2019

@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 19, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 19, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 19, 2019

PDF failed to compile for issue #1460 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1460/paper/paper.md): did not find expected key while parsing a block mapping at line 11 column 4 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon.rb:95:in load_yaml'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon.rb:78:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@whedon whedon added Jupyter Notebook Makefile TeX labels May 19, 2019

@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 19, 2019

👋 @RuthAngus - this PR should fix your paper compilation issues.
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 20, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 20, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 20, 2019

PDF failed to compile for issue #1460 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1460/paper/paper.md): could not find expected ':' while scanning a simple key at line 18 column 4 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon.rb:95:in load_yaml'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon.rb:78:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-fc4c5c749ca9/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 20, 2019

Sorry, looks like you need this fix too.

@RuthAngus - does this paper accompany a submission to a AAS journal?
@RuthAngus

This comment has been minimized.

Sign in to view
Copy link

commented May 20, 2019

Thanks, @arfon! Yes, it does -- I submitted a full-length paper to AJ about the method!

@arfon arfon added the AAS label May 20, 2019

@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 20, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 20, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 20, 2019

👉 Check article proof 📄 👈

@danielskatz

This comment has been minimized.

Sign in to view
Copy link

commented May 20, 2019

👋 @arfon - do you want to edit this submission?
@arfon

This comment has been minimized.

Sign in to view
Copy link
Member

commented May 20, 2019

@whedon assign @arfon as editor

@whedon whedon assigned arfon May 20, 2019

@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 20, 2019

OK, the editor is @arfon
@RuthAngus

This comment has been minimized.

Sign in to view
Copy link

commented May 20, 2019

Hi @arfon! I noticed a typo in the paper which I have fixed now!
@danielskatz

This comment has been minimized.

Sign in to view
Copy link

commented May 20, 2019

@whedon generate pdf
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 20, 2019 

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

commented May 20, 2019

👉 Check article proof 📄 👈

@danielskatz

This comment has been minimized.

Sign in to view
Copy link

commented May 20, 2019

👋 RuthAngus - you can also tell @whedon to do this at any time by putting the same command (@whedon generate pdf) in a new comment
@RuthAngus

This comment has been minimized.

Sign in to view
Copy link

commented May 20, 2019

@arfon sweet, thanks! I'll do that next time!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.