Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: The MTPy software package for magnetotelluric data analysis and visualisation #1358
Comments
whedon
assigned
lheagy
Mar 31, 2019
whedon
added
the
review
label
Mar 31, 2019
whedon
referenced this issue
Mar 31, 2019
Closed
[PRE REVIEW]: The MTPy software package for magnetotelluric data analysis and visualisation #1355
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @JKutt it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1358 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon.rb:83:in |
This comment has been minimized.
This comment has been minimized.
The author @alkirkby mentioned that she will fix the images in the paper on monday. Please let me know if you have any questions! |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
Mar 31, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1358 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon.rb:83:in |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
Mar 31, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
Mar 31, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Apr 1, 2019
This was referenced
This comment has been minimized.
This comment has been minimized.
Hi @lheagy, I managed to complete my review! I had a bit of a stumble at first getting things running but after following the Linux install more thoroughly I managed to get it going. Once up and running everything went quite smooth! A lot of good stuff in here. I found a few things and created an issue for one but the others already exist (e.g. error with print statements due to python 2 vs. 3). |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
Apr 3, 2019
Hey @JKutt, thanks for the review! We're glad you managed to install MTPy in the end, but we are tidying up some of the issues at the moment to make it easier for users. |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
Apr 5, 2019
This comment has been minimized.
This comment has been minimized.
Hi @alkirkby the "print" statements issue was brought up in MTgeophysics/mtpy#63 |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
Apr 8, 2019
Hi @JKutt, Fei tells me that the print statements issue was resolved, are you able to specify where in MTPy you're encountering these issues? |
This comment has been minimized.
This comment has been minimized.
@alkirkby sorry for the late reply, missed this one. I can't quite remember off the top of my head but it was in places where "print" is used instead of "print()" |
This comment has been minimized.
This comment has been minimized.
zhang01GA
commented
Apr 18, 2019
Hi @JKutt and @alkirkby: Today, I applied 2to3 to every *.py script in mtpy. But had not found any print statement issue. Please let me know. Thanks |
This comment has been minimized.
This comment has been minimized.
Thanks @zhang01GA! @JKutt, would you mind taking another look when you have a chance? |
This comment has been minimized.
This comment has been minimized.
All seems good now! No issues second time around. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
May 1, 2019
Hi @lheagy, okay great! @zhang01GA is looking into the documentation issue and will link the user guide from the main page. I've just fixed the doi issue. Nearly there! |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
May 2, 2019
Hi @lheagy, @zhang01GA has now fixed the documentation issue and has added a link to the user guide to the front page. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
whedon
assigned
JKutt
May 6, 2019
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
May 10, 2019
Great thanks @lheagy, |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
May 21, 2019
Hi @lheagy, |
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
May 21, 2019
version number is 1.0 |
This comment has been minimized.
This comment has been minimized.
@whedon set 10.5281/zenodo.2698634 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.2698634 is the archive. |
This comment has been minimized.
This comment has been minimized.
@whedon set 1.0 as version |
This comment has been minimized.
This comment has been minimized.
OK. 1.0 is the version. |
This comment has been minimized.
This comment has been minimized.
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@whedon set v1.0 as version |
This comment has been minimized.
This comment has been minimized.
OK. v1.0 is the version. |
lheagy
added
the
accepted
label
May 21, 2019
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
alkirkby
commented
May 21, 2019
@lheagy, ok no worries, done. |
This comment has been minimized.
This comment has been minimized.
Many thanks @JKutt for your speedy review! and congratulations @alkirkby and team on your submission |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
May 22, 2019
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
May 22, 2019
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#709, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
May 22, 2019
@alkirkby - I see a couple of reference problems that I've tried to fix via MTgeophysics/mtpy#82 One is opening quotes that were backwards, and the other is an underscore that caused a URL to not work right. I'm sure my fix will work for the quotes, but I'm not sure it will work for the URL. Can you accept the PR, and see if paper will compile? If not, we can try to fix the underscore in the URL another way. |
whedon commentedMar 31, 2019
•
edited
Submitting author: @alkirkby (Alison Kirkby)
Repository: https://github.com/MTgeophysics/mtpy
Version: v1.0
Editor: @lheagy
Reviewer: @JKutt
Archive: 10.5281/zenodo.2698634
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@JKutt, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @lheagy know.
Review checklist for @JKutt
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?