Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upExtractDomain mistakenly checks source first then url #277
Comments
borislin
self-assigned this
Oct 16, 2018
borislin
referenced this issue
Oct 16, 2018
Merged
Patch for #277: Fix bug and unit test for ExtractDomain #278
ruebot
added
bug
in progress
labels
Oct 17, 2018
ruebot
closed this
in
2c66b09
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
borislin commentedOct 16, 2018
Describe the bug
ExtractDomain
mistakenly checkssource
first thenurl
.To Reproduce
Steps to reproduce the behavior:
data2
variable inExtractDomainTest
to be the following:private val data2 = Seq.newBuilder.+=( (index, "http://www.umiacs.umd.edu/~jimmylin/", umiacs), ("https://github.com/lintool", "http://www.umiacs.umd.edu/~jimmylin/", "github.com"), (index, "https://github.com/lintool", "github.com")).result()
mvn clean package
Expected behavior
mvn clean package
should not produce any error after fixing the unit testExtractDomainTest
. Build should succeed.Environment information