Skip to content

/CLAW forked from Islandora/islandora

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'become' is not a valid attribute for a TaskInclude #1136

Closed
DonRichards opened this issue May 31, 2019 · 4 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DonRichards @ruebot @whikloj
@DonRichards
Copy link
Member

commented May 31, 2019

I'm running OSX WITH Ansible v2.8.0

$ vagrant up
....
....
....

ERROR! 'become' is not a valid attribute for a TaskInclude

The error appears to be in '/Users/don/Desktop/github/claw-playbook/roles/external/Islandora-Devops.matomo/tasks/main.yml': line 23, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


- include_tasks: db-pgsql.yml
  ^ here

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

Screen Shot 2019-05-31 at 1 37 58 PM
@ruebot

This comment has been minimized.

Sign in to view
Copy link

commented May 31, 2019

Islandora-Devops/ansible-role-matomo#2
@whikloj

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 1, 2019

This is clearly an ansible version issue, I'm still on a 2.7.x version and did not require this. So we should try this patch on 2.7 and see if it is backwards compatible or if we'll require people to update their ansible

@dannylamb dannylamb closed this in Islandora-Devops/ansible-role-matomo@f9c6f54 Jun 2, 2019

@DonRichards

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jun 3, 2019

@whikloj Just a thought, we work on many projects that use Ansible. Although I currently am not going to have an issue with rolling back to an earlier version this might cause others issues. 2.8 incorporated several new features like better interpreter discovery. Asking people to use an older version doesn't seem like the best solution but I do understand that attempting such a large modification wouldn't be wise during a version release. - 2 cents.
@whikloj

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 3, 2019

@DonRichards I am not asking people to roll back, I'm asking if the proposed change in this PR will work with an older version (read: Ansible 2.7) to not force all users not currently using Ansible 2.8 to immediately upgrade making it backwards compatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.