Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upReduce Sigma.js Minimum Node Size #190
Comments
ianmilligan1
added
enhancement
core-feature
labels
Aug 30, 2018
ianmilligan1
self-assigned this
Aug 30, 2018
ianmilligan1
added
the
on hold
label
Aug 30, 2018
ianmilligan1
referenced this issue
Aug 30, 2018
Merged
Take a better approach to scaling using normalized (log(x)) formula. #46
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ruebot
Sep 2, 2018
Member
FYI: I'll have to manually run GraphPass on all existing graphml
files in production once we do this.
FYI: I'll have to manually run GraphPass on all existing |
ruebot
closed this
in
553cd30
Sep 2, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ianmilligan1
Sep 2, 2018
Member
It will update automatically as the change is to sigma and not the files it’s running on - so no need to rerun graphpass!
It will update automatically as the change is to sigma and not the files it’s running on - so no need to rerun graphpass! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ianmilligan1
Sep 2, 2018
Member
(But yeah, once the graphpass version is updated, that is true... long weekend brain not connecting the separate issues and PRs)
(But yeah, once the graphpass version is updated, that is true... long weekend brain not connecting the separate issues and PRs) |
ianmilligan1 commentedAug 30, 2018
Is your feature request related to a problem? Please describe.
With new GraphPass, the minimum node size needs to be reduced. Nodes seem slightly larger with the new approach to node scaling (as discussed on this Pull Request. I've tested about thirty diagrams in sigma.js and I think changing the min node size from 3 to 1 would be ideal with this new approach.
Describe the solution you'd like
In
graphs.js
(inapp/assets/javascripts
), change:to
This should not be done until new GraphPass is brought into production.
Additional context
I've been putting screenshots into the Slack channel, but for example:
Collection 10004
Figure 1: Original, minNodeSize of 3. Note that the clusters of nodes run together, making the mouse over too difficult.
Figure 2: Suggested solution, minNodeSize of 1. Note that clusters of nodes are more legible, making a mouse over easy as in Figure 3.
Figure 3: With mouse over
Collection 10371
Figure 1: Same as above, minNodeSize of 3
Figure 2: minNodeSize of 1, makes selecting nodes easier
Figure 3: minNodeSize of 1, able to navigate diagram