New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for ExtractGraph.scala #49

Closed
ruebot opened this Issue Oct 2, 2017 · 6 comments

Comments

3 participants
@ruebot
Member

ruebot commented Oct 2, 2017

ExtractGraph.scala has no test coverage. We need to create tests for it.

@ruebot

This comment has been minimized.

Member

ruebot commented Oct 13, 2017

Partially resolved with: f28c6e1

@ruebot ruebot moved this from To Do to In Progress in Test coverage Oct 13, 2017

@greebie

This comment has been minimized.

Contributor

greebie commented Jan 11, 2018

This is up to 94%. I am lost as to why we do not have 100%, but it relates to the Edges & Nodes case classes.

@ruebot ruebot added the URA-Task label Feb 5, 2018

@ruebot ruebot moved this from In Progress to To Do in Test coverage May 21, 2018

@greebie

This comment has been minimized.

Contributor

greebie commented Aug 10, 2018

As part of #203 ExtractGraph has been deprecated. I can't remember why, but the tests have been commented out since it started.

I think we can leave this. Except that I like the name ExtractGraph over ExtractGraphX.

@ianmilligan1

This comment has been minimized.

Member

ianmilligan1 commented Nov 28, 2018

With #291 merged, ExtractGraph has been removed in ab32df4.

ExtractGraphX coverage is at 92%. CodeCov here. Should we keep ticket open under new name to try to up that, or close?

@ruebot

This comment has been minimized.

Member

ruebot commented Nov 29, 2018

Closed with ab32df4

ExtractGraphX issue: #294

@ruebot ruebot closed this Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment