Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upsheldon test #3
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
May 30, 2019
|
This comment has been minimized.
This comment has been minimized.
I'm not sure why Sheldon isn't picking this up. I'm looking into it. |
This comment has been minimized.
This comment has been minimized.
Can you merge the latest |
This comment has been minimized.
This comment has been minimized.
Oh wait -- the github token. Hold on. |
retorquere
added some commits
May 30, 2019
This comment has been minimized.
This comment has been minimized.
The github token has been set up, and the travis config updates bundler before sheldon runs now -- can you merge latest from this branch and re-push? |
retorquere
and others
added some commits
May 30, 2019
This comment has been minimized.
This comment has been minimized.
And that is the one thing I had not considered. For security reasons, encrypted variables (such as authentication tokens) are not set in PRs for security reasons (otherwise a malicious actor could just Damn. I'm truly sorry for all this noise BTW -- can I submit PRs myself on my own repo so I can test myself? Or can I push changes onto this PR myself? I'll have to fall back to the other option I had in mind -- publishing the test assets somewhere like transfer.sh and having sheldon pick them up. I'll look into this. |
This comment has been minimized.
This comment has been minimized.
You can create a different branch and make PRs between them (and no worries -- really appreciate all your work on this) |
retorquere
and others
added some commits
Jun 3, 2019
This comment has been minimized.
This comment has been minimized.
OK, let's see if that works. Also happy to just open a new PR |
This comment has been minimized.
This comment has been minimized.
We'll need a new PR to verify the welcome still works, but the actual thing that's changed to have sheldon pick up the details should work here too. Did you merge the |
This comment has been minimized.
This comment has been minimized.
I did merge reporting, but not seeing |
This comment has been minimized.
This comment has been minimized.
Forgot to commit |
This comment has been minimized.
This comment has been minimized.
It's in the reporting branch now. |
retorquere
added some commits
Jun 4, 2019
This comment has been minimized.
This comment has been minimized.
never mind -- I can see the hidden message is successfully put in the log. The question is now why it's not being picked up by my instance of shel-bot. On it. |
This comment has been minimized.
This comment has been minimized.
I had misconfigured the webhook URL. Can you try again? |
This comment has been minimized.
This comment has been minimized.
I think we're getting there -- there's something really strange going on with owner-submitted PRs, if you look at https://travis-ci.org/retorquere/styles/builds/541564390 you'll see that travis builds this on "master" rather than "junk", and Shel-gem bails if building on master (as there would be nothing to compare to for styles). I've submitted a support request to Travis for this, but it means effectively I cannot test using my own PRs. |
retorquere
added some commits
Jun 5, 2019
This comment has been minimized.
This comment has been minimized.
Getting the log from shel-bot seems to get a mutilated version of the log. When I fetch the log later, it is fine. Maybe a race condition - im in touch with Travis support again. The way out would be to post the snippet to a well-know url, which gets us back to a anon-write to an b2 or s3 bucket. How do you guys feel about this. I'd never have thought that just getting the snippet to shel-bot would be the bulk of the work! |
retorquere
added some commits
Jun 7, 2019
This comment has been minimized.
This comment has been minimized.
finally got it to work. In the end I've added a memcache addon to sheldon. It doesn't really matter what's used to store the build details as long as shel-bot has read/write access to it, so I'm open to suggestions. Hiding in the log worked in the end, but the log display of Travis would never consistently interpret the hiding ANSI codes so you'd always see some of the details leak out to the display. Can you try merging the |
This comment has been minimized.
This comment has been minimized.
memcache has the benefit that it'll auto-expire the snippets to keep size down (given that they so far have been below 25KB, the 30MB free allotment should go a long way), but S3 also has auto-expiring of assets, so that should also work and be low-maintenance. Heroku Pg could also be made to work. |
adam3smith
added some commits
May 30, 2019
This comment has been minimized.
This comment has been minimized.
1 test failedacta-naturae: must validate against the CSL 1.0.1 schema
Please check the test report for details. |
This comment has been minimized.
This comment has been minimized.
Alright, that works! So then we need to talk about the persistence method for Sheldon. Here's some of the possibilities I see offhand:
|
This comment has been minimized.
This comment has been minimized.
Hooray indeed! Can you prep this as PRs to our repos? |
This comment has been minimized.
This comment has been minimized.
Will do. |
This comment has been minimized.
This comment has been minimized.
I'd hugely appreciate it if I could submit the PRs as-is and that github squash-and-merge is used to mash everything together. After all this time, rebase still terrifies me. By necessity I will be submitting 3 PRs, to
At this stage, Sheldon should be ready to serve the new-style requests, but since it s backwards compatible, it won't do anything yet.
Agreed? I'll precede the PR names with "Sheldon build details:" to make them easily recognizable. |
This comment has been minimized.
This comment has been minimized.
Absolutely -- Dan at Zotero is much pickier about this than we are. (brag: I did the remote branch pull and rebase for this without googling/manual. I feel like I've graduated Defense against the Dark Arts II ) Yes, order for PRs sounds exactly right. Let me know if you need anything from us in the process (other than reviewing & merging PRs, or course). |
This comment has been minimized.
This comment has been minimized.
It depends on how much effort you want post-merge. I can prep the |
This comment has been minimized.
This comment has been minimized.
I think Dan has allowed me to default to squash-and-merge before. I do understand why he wouldn't want the full messy commit trail
I stand in awe. For me, this process vies for status as apex-stressor with doing a PhD. |
This comment has been minimized.
This comment has been minimized.
Yes, let's do that. I think we should get the Sheldon update merged quickly. |
adam3smith commentedMay 30, 2019
No description provided.