Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesUpdate Primo Normalized XML.js #1951
Conversation
This comment has been minimized.
This comment has been minimized.
I can look into the linter errors/warnings later, but I would prefer to first know that these changes are fine. |
This comment has been minimized.
This comment has been minimized.
(
instead of
) |
This comment has been minimized.
This comment has been minimized.
@retorquere -- I think you built that part of CI? Seems to struggle with filenames with spaces in it (see zuphilip's post above and travis details) |
adam3smith
reviewed
Jun 9, 2019
I'm mostly fine with this. One question about the new test you added inline. |
"items": [ | ||
{ | ||
"itemType": "book", | ||
"title": "Zur Medienöffentlichkeit der Dritten Gewalt rechtliche Aspekte des Zugangs der Medien zur Rechtsprechung im Verfassungsstaat des Grundgesetzes", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zuphilip
Jun 9, 2019
Author
Collaborator
It is not in the PNX data, which is a little strange, because it is in the underlying data. However, I don't see anything we can do in the translator for this case.
This comment has been minimized.
This comment has been minimized.
@adam3smith I'm looking into it |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Currently, we add for example tags for all name forms of Germany which are part of the search section, e.g. https://primo-49man.hosted.exlibrisgroup.com/permalink/f/19ojnqi/MAN_ALMA21126560510002561 . It makes sense to have several name forms saved in the search section, because then all of them can be search in primo, but the normalized form is what you see in the display section.
Do you mean the "Schlagwortketten" like |
zuphilip commentedJun 3, 2019
search sections