Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Primo Normalized XML.js #1951

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@zuphilip
Copy link
Collaborator

commented Jun 3, 2019

  • handle also cases where place is part of publisher string
  • handle also cases where seriesNumber is part of series
  • prefer subjects in display section over subjects in
    search sections
Update Primo Normalized XML.js
- handle also cases where place is part of publisher string
- handle also cases where seriesNumber is part of series
- prefer subjects in display section over subjects in
search sections
@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 3, 2019

I can look into the linter errors/warnings later, but I would prefer to first know that these changes are fine.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 3, 2019

(
The test is not running the correct command, but rather it is running:

teslint "Primo" "Normalized" "XML.js"

instead of

teslint "Primo Normalized XML.js"

)

@adam3smith

This comment has been minimized.

Copy link
Collaborator

commented Jun 9, 2019

@retorquere -- I think you built that part of CI? Seems to struggle with filenames with spaces in it (see zuphilip's post above and travis details)

@adam3smith
Copy link
Collaborator

left a comment

I'm mostly fine with this. One question about the new test you added inline.
What's the rationale for the change in keywords/tags from search to display? Relatedly, do we generally import these long hierarchical tags and does that makes sense as a practice?

"items": [
{
"itemType": "book",
"title": "Zur Medienöffentlichkeit der Dritten Gewalt rechtliche Aspekte des Zugangs der Medien zur Rechtsprechung im Verfassungsstaat des Grundgesetzes",

This comment has been minimized.

Copy link
@adam3smith

adam3smith Jun 9, 2019

Collaborator

Anyway we could have figured out the subtitle here?

This comment has been minimized.

Copy link
@zuphilip

zuphilip Jun 9, 2019

Author Collaborator

It is not in the PNX data, which is a little strange, because it is in the underlying data. However, I don't see anything we can do in the translator for this case.

@retorquere

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@adam3smith I'm looking into it

@retorquere

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 9, 2019

What's the rationale for the change in keywords/tags from search to display?

Currently, we add for example tags for all name forms of Germany which are part of the search section, e.g. https://primo-49man.hosted.exlibrisgroup.com/permalink/f/19ojnqi/MAN_ALMA21126560510002561 . It makes sense to have several name forms saved in the search section, because then all of them can be search in primo, but the normalized form is what you see in the display section.

Relatedly, do we generally import these long hierarchical tags and does that makes sense as a practice?

Do you mean the "Schlagwortketten" like Deutschland / Gerichtsberichterstattung / Elektronische Medien / Verbot / Verfassungsmäßigkeit? We could split this up into individual tags, as I would say is more what Zotero does. Should I do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.