Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Tools for Prototyping with 3D Ultrasonics in ROS #1519

Open
whedon opened this issue Jun 22, 2019 · 21 comments

Comments

Projects
None yet
5 participants
@whedon
Copy link
Collaborator

commented Jun 22, 2019

Submitting author: @adi3 (Adi Singh)
Repository: https://gitlab.com/toposens/public/ros-packages
Version: v1.1.0
Editor: @gkthiruvathukal
Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @adi3. Currently, there isn't an JOSS editor assigned to your paper.

@adi3 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Jun 22, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2019

Failed to discover a valid open source license.

@whedon whedon added the TeX label Jun 22, 2019

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2019

PDF failed to compile for issue #1519 with the following error:

sh: 0: getcwd() failed: No such file or directory
pandoc: 10.21105.joss.01519.pdf: openBinaryFile: does not exist (No such file or directory)
Looks like we failed to compile the PDF

@danielskatz

This comment has been minimized.

Copy link

commented Jun 22, 2019

@adi3 - I don't see the software that you want to submit - it seems like you have just submitted a paper repo. Can I suggest that you withdraw this, and then submit the software repository, which should contain a paper.md file in a directory in that repository? Take a look at the repositories in some of the accepted papers in http://joss.theoj.org ...

@ts-adi

This comment has been minimized.

Copy link

commented Jun 22, 2019

@danielskatz - Sorry, this was an oversight on my part. This is the code repository: https://gitlab.com/toposens/public/ros-packages/

I don't mind withdrawing and resubmitting the paper, but we'd like to keep the contents of the ROS code repo limited to what's relevant to the ROS framework. In doing so, we are following the precedent set by ros_control, which has been published in JOSS; they too separate their code repo (https://github.com/ros-controls/ros2_control) and their paper repo (https://github.com/ros-controls/joss_paper).

So can I resubmit the way it is currently structured?

@danielskatz

This comment has been minimized.

Copy link

commented Jun 22, 2019

👋 @arfon, can you help here?

@arfon

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

👋 @arfon, can you help here?

@ts-adi - could you add the paper to a branch of the https://gitlab.com/toposens/public/ros-packages repository. We don't need this branch to ever be merged to master but it's much more convenient for the paper to be present somewhere in the repository. Once the JOSS review is complete, you can simply delete that branch.

@ts-adi

This comment has been minimized.

Copy link

commented Jun 23, 2019

@arfon Thanks, that is a suitable solution. I've created a branch joss_paper in the software repository https://gitlab.com/toposens/public/ros-packages/tree/joss_paper and added the paper files there.

Should I still withdraw and resubmit?

@arfon

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

@whedon generate pdf from branch joss_paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 23, 2019

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 23, 2019

@arfon

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

Should I still withdraw and resubmit?

No, I think we're OK with how it is now. @danielskatz - we'll need to compile the papers from the joss_paper branch.

@danielskatz

This comment has been minimized.

Copy link

commented Jun 23, 2019

@gkthiruvathukal - Would you be willing to edit this submission?

@gkthiruvathukal

This comment has been minimized.

Copy link

commented Jun 23, 2019

Yes, @danielskatz.

@danielskatz

This comment has been minimized.

Copy link

commented Jun 23, 2019

@whedon assign @gkthiruvathukal as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 23, 2019

OK, the editor is @gkthiruvathukal

@danielskatz

This comment has been minimized.

Copy link

commented Jun 23, 2019

Note that you have to use @whedon generate pdf from branch joss_paper to generate the paper in this case...

@ts-adi

This comment has been minimized.

Copy link

commented Jun 23, 2019

@whedon generate pdf from branch joss_paper

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 23, 2019

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.