Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: Tools for Prototyping with 3D Ultrasonics in ROS #1519
Comments
whedon
added
the
pre-review
label
Jun 22, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Failed to discover a valid open source license. |
whedon
added
the
TeX
label
Jun 22, 2019
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1519 with the following error: sh: 0: getcwd() failed: No such file or directory |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jun 22, 2019
@adi3 - I don't see the software that you want to submit - it seems like you have just submitted a paper repo. Can I suggest that you withdraw this, and then submit the software repository, which should contain a paper.md file in a directory in that repository? Take a look at the repositories in some of the accepted papers in http://joss.theoj.org ... |
This comment has been minimized.
This comment has been minimized.
ts-adi
commented
Jun 22, 2019
@danielskatz - Sorry, this was an oversight on my part. This is the code repository: https://gitlab.com/toposens/public/ros-packages/ I don't mind withdrawing and resubmitting the paper, but we'd like to keep the contents of the ROS code repo limited to what's relevant to the ROS framework. In doing so, we are following the precedent set by ros_control, which has been published in JOSS; they too separate their code repo (https://github.com/ros-controls/ros2_control) and their paper repo (https://github.com/ros-controls/joss_paper). So can I resubmit the way it is currently structured? |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jun 22, 2019
|
This comment has been minimized.
This comment has been minimized.
@ts-adi - could you add the paper to a branch of the |
This comment has been minimized.
This comment has been minimized.
ts-adi
commented
Jun 23, 2019
•
@arfon Thanks, that is a suitable solution. I've created a branch Should I still withdraw and resubmit? |
This comment has been minimized.
This comment has been minimized.
@whedon generate pdf from branch joss_paper |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
No, I think we're OK with how it is now. @danielskatz - we'll need to compile the papers from the |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jun 23, 2019
@gkthiruvathukal - Would you be willing to edit this submission? |
This comment has been minimized.
This comment has been minimized.
gkthiruvathukal
commented
Jun 23, 2019
Yes, @danielskatz. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jun 23, 2019
@whedon assign @gkthiruvathukal as editor |
This comment has been minimized.
This comment has been minimized.
OK, the editor is @gkthiruvathukal |
whedon
assigned
gkthiruvathukal
Jun 23, 2019
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jun 23, 2019
Note that you have to use |
This comment has been minimized.
This comment has been minimized.
ts-adi
commented
Jun 23, 2019
@whedon generate pdf from branch joss_paper |
This comment has been minimized.
This comment has been minimized.
|
whedon commentedJun 22, 2019
•
edited
Submitting author: @adi3 (Adi Singh)
Repository: https://gitlab.com/toposens/public/ros-packages
Version: v1.1.0
Editor: @gkthiruvathukal
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @adi3. Currently, there isn't an JOSS editor assigned to your paper.
@adi3 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: