Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Washington Datathon Project - Issue 109 #110

Merged
merged 3 commits into from Mar 28, 2019

Conversation

Projects
3 participants
@SamFritz
Copy link
Member

SamFritz commented Mar 27, 2019

This PR addresses tasks listed in Issue 109

Template was used to display Washington projects to ensure responsive design.

Tasks addressed:

  • Team Project section
  • List team members
  • Project image as placeholder
  • Upload project slides and link to PDF
  • Update bottom section of webpage (hidden content) to follow template of other event pages
  • List Washington datathon under Events > past datathon
  • Removed Washington event page from main navigation menu
  • Updates events page: updated images and rework of intro paragraph

Testing:
Tested locally to make sure that images appear and links to pdf slides opens new tab.

Requested Reviewers:
@ianmilligan1 @ruebot this isn't an urgent ticket, but let me know if you see anything is missing. Would like to promote projects through newsletter and other channels later this week.

@SamFritz SamFritz self-assigned this Mar 27, 2019

@SamFritz SamFritz requested review from ruebot and ianmilligan1 Mar 27, 2019

@ianmilligan1
Copy link
Member

ianmilligan1 left a comment

Some minor tweaks and then I think this is good to go.

<ul>
<li>Yoo Young Lee, University of Ottawa</li>
<li>Christie Moffatt, National Library of Medicine</li>
<li>Anna St.Onge, York University Libraries</li>

This comment has been minimized.

Copy link
@ianmilligan1

ianmilligan1 Mar 27, 2019

Member

St.Onge -> St. Onge (add space)

This comment has been minimized.

Copy link
@ruebot

ruebot Mar 27, 2019

Member

No space there! Trust me :-D

This comment has been minimized.

Copy link
@ianmilligan1

ianmilligan1 Mar 27, 2019

Member

Oops!

<li>Grace Thomas, Library of Congress</li>
<li>James Jacobs, Stanford University</li>
<li>Laura Wrubel, George Washington University</li>
<li>Olive Kiechle, Heinrich-Heine-University Duesseldorf</li>

This comment has been minimized.

Copy link
@ianmilligan1

ianmilligan1 Mar 27, 2019

Member

Olive to Oliver

@ianmilligan1 ianmilligan1 added this to In Progress in GWU via automation Mar 27, 2019

@ruebot

ruebot approved these changes Mar 27, 2019

Copy link
Member

ruebot left a comment

Just the Oliver fix, and I think we're good.

@ianmilligan1 I'll leave it to you to merge and publish when the time comes if you'd like.

@ianmilligan1 ianmilligan1 merged commit 7816fe2 into master Mar 28, 2019

GWU automation moved this from In Progress to Complete Mar 28, 2019

@ianmilligan1 ianmilligan1 deleted the issue-109 branch Mar 28, 2019

@SamFritz SamFritz referenced this pull request Mar 28, 2019

Closed

Washington Datathon Final Projects #109

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.