Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAUT exits/dies on java.util.zip.ZipException: invalid distance too far back #246
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ianmilligan1
Aug 1, 2018
Member
Some more context from GitHub digging: the java.util.zip.ZipException: invalid distance code
error was fixed for WarcRecordUtils.java
in this commit. Here is the original issue, from back when AUT was Warcbase.
However, we never updated ArcRecordUtils.java
to introduce similar error handling for ARC files. It would be great if ArcRecordUtils.java
was updated to catch the this error.
Some more context from GitHub digging: the However, we never updated |
ianmilligan1
assigned
borislin
Aug 1, 2018
ianmilligan1
referenced this issue
Aug 12, 2018
Closed
Update ArcRecordUtils for better error handling #258
ruebot
added this to To Do
in 1.0.0 Release of AUT
Aug 13, 2018
ruebot
moved this from To Do
to In Progress
in 1.0.0 Release of AUT
Aug 13, 2018
ruebot
added
bug
URA-Task
in progress
labels
Aug 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
greebie
Sep 17, 2018
Contributor
Possibly related: #249 removed some try-catch calls checking for IOExceptions, favoring an Option approach. The justification (discussed in #212) was that IOExceptions should be caught in the ArchiveRecord class, instead of trying to manage them inside every string manipulation function.
However, this is a ZipException, so I do not think the problems are the same. (You can see in #249, that I avoided adding Options to the ArchiveRecord class because it would require refactoring.)
Possibly related: #249 removed some try-catch calls checking for IOExceptions, favoring an Option approach. The justification (discussed in #212) was that IOExceptions should be caught in the ArchiveRecord class, instead of trying to manage them inside every string manipulation function. However, this is a ZipException, so I do not think the problems are the same. (You can see in #249, that I avoided adding Options to the ArchiveRecord class because it would require refactoring.) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Thanks @ruebot. Just wanted to be sure I did not break things. |
ruebot commentedJul 27, 2018
•
edited
Describe the bug
Came across this when processing a user's collection on cloud.archivesunleashed.org, using
aut-0.16.0
. The collection appears to have a couple problematic warcs, which throw this error:To Reproduce
Steps to reproduce the behavior (e.g.):
Expected behavior
I think we should catch this error, log it, and move on.
Additional context
I'll check with the user, and see if it is ok whether to use one of these files in a test.
tag: @lintool @ianmilligan1