Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upmodern-humanities-research-association.csl #4062
Comments
MartinPaulEve
referenced this issue
Apr 27, 2019
Merged
Update MHRA to use volume.issue format. Addresses issue #4062 #4064
adam3smith
closed this
in
c7ad649
Apr 27, 2019
This comment has been minimized.
This comment has been minimized.
|
HI @adam3smith -- just to check here -- you removed my conditional for issue, which means that if there is no issue specified, it will render the "." without a trailing issue number, I believe...? |
This comment has been minimized.
This comment has been minimized.
|
No -- the delimiter only gets placed between the two items in the group, i.e. won't show up if either is absent. That's why there's no need for the conditional. |
This comment has been minimized.
This comment has been minimized.
|
Apologies - my bad! |
This comment has been minimized.
This comment has been minimized.
|
Nothing to apologize for -- thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
MartinPaulEve commentedApr 25, 2019
I think this might be a recurrence of #1672 but currently modern-humanities-research-association.csl is not appending issue after volume for some reason (i.e. it gives "27" rather than "27.1").
The same metadata fed into modern-humanities-research-association-author-date.csl is producing the volume.issue format.