/warclight

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change field searches to use fields instead of handlers #45

Closed
ruebot opened this Issue Oct 8, 2018 · 2 comments

Comments

Assignees

@ruebot ruebot

Labels
Projects
None yet
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
@ruebot
Member

ruebot commented Oct 8, 2018

If we do something similar to what @anjackson did in this commit, we'd leave less of a burden on the implementer to setup a custom solrconfig.xml like we ship here, and if they already have a Solr index two setup with the same or similar schema.xml that webarchive-discovery ships, it would be an easier drop-in.

warclight/lib/generators/warclight/templates/catalog_controller.rb

Lines 120 to 134 in ef0c872

config.add_search_field 'title', label: 'Title' do |field|
field.qt = 'title_search'
end
config.add_search_field 'content', label: 'Content' do |field|
field.qt = 'content_search'
end
config.add_search_field 'url', label: 'URL' do |field|
field.qt = 'url_search'
end
config.add_search_field 'host', label: 'Host' do |field|
field.qt = 'host_search'
end

Less things to maintain?

@anjackson @ianmilligan1 let me know what you think.

@ruebot ruebot added the discussion label Oct 8, 2018

@ruebot ruebot self-assigned this Oct 8, 2018

@ianmilligan1

This comment has been minimized.

Show comment
Hide comment
@ianmilligan1

ianmilligan1 Oct 8, 2018

Member

I'm far from a Solr expert, so I'd defer to you and @anjackson, but going down this route makes perfect sense to me!
Member

ianmilligan1 commented Oct 8, 2018

I'm far from a Solr expert, so I'd defer to you and @anjackson, but going down this route makes perfect sense to me!
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Oct 11, 2018

Member

After some good discussion in IIPC webarchive-discovery channel, I'm going to move forward with this. It'll make Warclight easier to implement for webarchive-discovery users.
Member

ruebot commented Oct 11, 2018

After some good discussion in IIPC webarchive-discovery channel, I'm going to move forward with this. It'll make Warclight easier to implement for webarchive-discovery users.

@ruebot ruebot referenced this issue Oct 12, 2018

Closed

Use the default webarchive-discovery Solr 7 config #46

@ruebot ruebot closed this in 3e034d2 Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment