Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: X.509 Compliant Hybrid Certificates for the Post-Quantum Transition #1606
Comments
whedon
assigned
danielskatz
Jul 29, 2019
whedon
added
the
review
label
Jul 29, 2019
whedon
referenced this issue
Jul 29, 2019
Closed
[PRE REVIEW]: X.509 Compliant Hybrid Certificates for the Post-Quantum Transition #1561
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @jbasney, @jteheran it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Jul 29, 2019
Thanks for being willing to do this, and if you have any questions, please ask me |
whedon
assigned
jbasney and
jteheran
Jul 30, 2019
Aug 5, 2019
This was referenced
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 9, 2019
|
This comment has been minimized.
This comment has been minimized.
j-braun
commented
Aug 9, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
j-braun
commented
Aug 9, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
j-braun
commented
Aug 9, 2019
@danielskatz - we took care of the issues and fixed them |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 9, 2019
This comment has been minimized.
This comment has been minimized.
looks good to me |
This comment has been minimized.
This comment has been minimized.
looks good to me too |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 9, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 9, 2019
@whedon check references |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 9, 2019
@j-braun - please merge CROSSINGTUD/bc-hybrid-certificates#4 or let me know any changes you don't agree with. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 9, 2019
After that, please make a Zenodo archive of the software, and report the DOI here. If the version number has changed, please report that here as well. |
This comment has been minimized.
This comment has been minimized.
j-braun
commented
Aug 10, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
j-braun
commented
Aug 10, 2019
@danielskatz I agreed to your changes, and only fixed one last typo. @danielskatz, @jbasney, @jteheran - thank you very much for your quick review and support |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 10, 2019
@whedon set 1.0.1 as version |
This comment has been minimized.
This comment has been minimized.
OK. 1.0.1 is the version. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 10, 2019
@whedon set 10.5281/zenodo.3365225 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3365225 is the archive. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 10, 2019
@j-braun - Can you change the title of the zenodo archive to match the paper title? |
This comment has been minimized.
This comment has been minimized.
j-braun
commented
Aug 12, 2019
@danielskatz - Updating the title in Zenodo was not possible. Instead Icreated a new release matching the paper title. This triggered a new archive, but also created a new DOI. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 12, 2019
@whedon set 10.5281/zenodo.3365786 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3365786 is the archive. |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 12, 2019
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#893, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 12, 2019
@whedon accept deposit=true |
whedon
added
the
accepted
label
Aug 12, 2019
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Aug 12, 2019
danielskatz
closed this
Aug 12, 2019
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedJul 29, 2019
•
edited
Submitting author: @j-braun (Johannes Braun)
Repository: https://github.com/CROSSINGTUD/bc-hybrid-certificates
Version: 1.0.1
Editor: @danielskatz
Reviewer: @jbasney, @jteheran
Archive: 10.5281/zenodo.3365786
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jbasney & @jteheran, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
Review checklist for @jbasney
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @jteheran
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?