Skip to content

/auk-notebooks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add B.C. Teachers' Labour Dispute (2014); resolves #13. #26

Merged
merged 4 commits into from Mar 6, 2019

Conversation

Reviewers

@greebie greebie

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @greebie @ianmilligan1
@ruebot
Copy link
Member

commented Mar 5, 2019

  • Remove existing dataset
  • Add 4867 data
  • Update example notebook
  • Update README
@ruebot
Add B.C. Teachers' Labour Dispute (2014); resolves #13. 
- Remove existing dataset
- Add 4867 data
- Update example notebook
- Update README
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
0a89abd

@ruebot ruebot requested review from ianmilligan1 and greebie Mar 5, 2019

@greebie

This comment has been minimized.

Sign in to view
Copy link
Collaborator

commented Mar 5, 2019

Works well technically, but the sentimentality results gives something not very interesting:
image

I'll take a look at this tomorrow (on my way to class right now).
@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Mar 5, 2019

Fair enough. I'll re-sample the dataset with shuf instead of tail.

ruebot added some commits Mar 5, 2019

@ruebot
re-sample data
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
2e4e43f
@ruebot
Update README for new sample
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
1651952
@ianmilligan1

ianmilligan1 requested changes Mar 6, 2019
View changes

Copy link
Member

left a comment •
edited

Looks good! The sampling worked very well as the two screenshots below show:

screen shot 2019-03-05 at 9 14 04 pm

screen shot 2019-03-05 at 9 14 51 pm

The only thing that I would consider changing is adding the default collection number "4867" to the setup cell in auk-notebook.ipynb i.e.

# Add the collection id of your Archive-It collection:
coll_id = "4867"

That way it runs out of the box once dependencies are involved, and they can see the template for where they should swap in their own variable. Maybe we could put a quick note in the comment too to note that they should change the value if they want to use their own data?
@ruebot
review
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
a2fc528
@ianmilligan1

ianmilligan1 approved these changes Mar 6, 2019
View changes

@greebie

greebie approved these changes Mar 6, 2019
View changes

Copy link
Collaborator

left a comment

Works great! lgtm.

@ianmilligan1 ianmilligan1 merged commit 7e20729 into master Mar 6, 2019
1 check passed

1 check passed

ci/dockercloud Your tests passed in Docker Cloud
Details

@ianmilligan1 ianmilligan1 deleted the issue-13 branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.