Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New contributor accession naming guidelines -- DISCUSSION #84

Open
meier-rene opened this issue Jun 28, 2019 · 5 comments

Comments

@meier-rene
Copy link
Collaborator

commented Jun 28, 2019

I would like to develop some guidelines for new contributors how to name their accession and how and when to create new directories. This has become urgent due to some email discussion about new contributors and particular some new contributions, like #82.

There are different demands for which we need to find some compromise.

I, as a maintainer of the whole project would like to have data compact and not cluttered. Some directories are desired but not too much. Technical we only support one level with directories at the moment.

There are demands from contributors. They would like to separate their contribution by contributing group, but also sometimes by a specific project, which supported the creation of this records. I expect that a entry in the COMMENT section does not suffice. For them its most likely also matter of public image. Sometimes this separation is not an issue, because there is just one contributing person/group at a particular institution. In other cases more "separation" or "distinguishability" is desired. You all know that everyone has to justify his/her projects somehow...

Possible solutions - technical view -:
-most easy way for contributors: allow subdirectories in the institution directories. This creates major headaches on my side, because it would mean a lot of adjustments to the codebase
-use a directory naming scheme like the one which is already in the current data and resulted in this this discussion issue. Examples for the scheme could be RIKEN_IMS, RIKEN_NPDepo... This is a easy solution because it works right now. Only drawback is the increasing directory number which makes the project view bit more confusing.
-ease the requirement on accession naming, thats easy to implement but might not be sufficient "distinguishability"

Besides directory naming we also have the question of accession naming.

@schymane

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Related to this: do we have an inventory anywhere of the 2-3 letter codes already in use in MassBank accession IDs @meier-rene?
@MaliRemorker

@meier-rene

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 26, 2019

Yes, we have. I recently updated the list of contributors. https://github.com/MassBank/MassBank-data/blob/master/List_of_Contributors_Prefixes_and_Projects.md

@schymane

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Brilliant, thank you! Looks like Luxembourg records should indeed start with L ;-) @MaliRemorker

@tsufz

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Yes, but the UFZ UN and UP assignments are missing now. @meier-rene, could you add them again, please?

@meier-rene

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 26, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.