Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate how to load .doc, .docx, and .pdf files #217

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@billdenney
Copy link
Contributor

commented Sep 5, 2019

Fixes #210, with and addition of .pdf to the list, too. (Also, while I thought this change sufficient for including in NEWS, I didn't think that my contribution warranted my name as a full contributor.)

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR
@codecov-io

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #217 into master will decrease coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   81.47%   81.16%   -0.32%     
==========================================
  Files          18       18              
  Lines         880      860      -20     
==========================================
- Hits          717      698      -19     
+ Misses        163      162       -1
Impacted Files Coverage Δ
R/extensions.R 100% <100%> (ø) ⬆️
R/suggestions.R 87.5% <0%> (-1.98%) ⬇️
R/import_list.R 75.32% <0%> (-1.79%) ⬇️
R/fwf2.R 60.52% <0%> (-1.02%) ⬇️
R/export_methods.R 89.28% <0%> (-0.52%) ⬇️
R/import_methods.R 73.74% <0%> (-0.18%) ⬇️
R/utils.R 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999a3d2...8d77766. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #217 into master will decrease coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   81.47%   81.16%   -0.32%     
==========================================
  Files          18       18              
  Lines         880      860      -20     
==========================================
- Hits          717      698      -19     
+ Misses        163      162       -1
Impacted Files Coverage Δ
R/extensions.R 100% <100%> (ø) ⬆️
R/suggestions.R 87.5% <0%> (-1.98%) ⬇️
R/import_list.R 75.32% <0%> (-1.79%) ⬇️
R/fwf2.R 60.52% <0%> (-1.02%) ⬇️
R/export_methods.R 89.28% <0%> (-0.52%) ⬇️
R/import_methods.R 73.74% <0%> (-0.18%) ⬇️
R/utils.R 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999a3d2...8d77766. Read the comment docs.

@leeper leeper merged commit 8d77766 into leeper:master Sep 9, 2019

4 checks passed

codecov/patch 100% of diff hit (target 81.47%)
Details
codecov/project Absolute coverage decreased by -0.31% but relative coverage increased by +18.52% compared to 999a3d2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@billdenney billdenney deleted the billdenney:additional-format-pointers branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.