Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIndicate how to load .doc, .docx, and .pdf files #217
+4
−0
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Sep 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 81.47% 81.16% -0.32%
==========================================
Files 18 18
Lines 880 860 -20
==========================================
- Hits 717 698 -19
+ Misses 163 162 -1
Continue to review full report at Codecov.
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Sep 5, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
==========================================
- Coverage 81.47% 81.16% -0.32%
==========================================
Files 18 18
Lines 880 860 -20
==========================================
- Hits 717 698 -19
+ Misses 163 162 -1
Continue to review full report at Codecov.
|
leeper
merged commit 8d77766
into
leeper:master
Sep 9, 2019
4 checks passed
codecov/project
Absolute coverage decreased by -0.31% but relative coverage increased by +18.52% compared to 999a3d2
Details
billdenney
deleted the
billdenney:additional-format-pointers
branch
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
billdenney commentedSep 5, 2019
•
edited
Fixes #210, with and addition of .pdf to the list, too. (Also, while I thought this change sufficient for including in NEWS, I didn't think that my contribution warranted my name as a full contributor.)
Please ensure the following before submitting a PR:
/R
not/man
and rundevtools::document()
to update documentation/tests
for any new functionality or bug fixR CMD check
runs without error before submitting the PR