Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: layout mismatch #8

Closed
gallardo opened this issue Sep 10, 2019 · 3 comments

Comments

@gallardo
Copy link

commented Sep 10, 2019

Trying to understand tests from https://github.com/Juris-M/jm-style-tests, there is a mismatch between the layout sections listed in https://github.com/citation-style-language/test-suite#fixture-layout and the sections in e.g. apa/style_test001.txt. This last one has:

  • MODE
  • KEYS
  • DESCRIPTION
  • RESULT
  • INPUT

but no

  • CSL

Furthermore, the mode all configured in style_test001.txt isn't mentioned in this doc.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

https://github.com/citation-style-language/test-suite#fixture-layout is for testing CSL processors, so it tests individual outputs (i.e. citation or bibliography) and minimal CSL needs to be part of the test. Because it applies to all processors, it's part of the CSL repository.

https://github.com/Juris-M/jm-style-tests isn't fully documented and is for testing styles against citeproc-js (which is why it's in the juris-m/citeproc-js repository, though the same tests could be used with other processors), so CSL is actually what's being tested. MODE all is just a logical extension of the logic in the processor text fixtures meaning both bibliography and citation.

@gallardo

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

Thanks, I see. I guess the confusion comes from the inaccurate statement from downstream https://github.com/Juris-M/citeproc-test-runner#test-layout:

CTR works from tests written in the idiosyncratic CSL test format, documented in the CSL test-suite repository.

@gallardo gallardo closed this Sep 10, 2019

@gallardo

This comment has been minimized.

Copy link
Author

commented Sep 10, 2019

😳 Now I read further:

and the tests generated by CTR (see below) differ in a few respects

Sorry for the disruption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.