Skip to content

/rio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the same argument filters as #222 for .import.rio_rdata, .import.rio_xls, and .import.rio_ods #223

Open
bokov opened this issue Sep 19, 2019 · 1 comment

Comments

@bokov
Copy link
Contributor

commented Sep 19, 2019

Please specify whether your issue is about:

  • a possible bug
  • a question about package functionality
  • a suggested code or documentation change, improvement to the code, or feature request

in #222, the intersect() and setdiff() functions were used to generically filter the arguments passed via ... so that only the ones recognized by the underlying import function would get passed to it.

The functions load(), readxl::read_xls(), and readODS::read_ods() underlying .import.rio_rdata(), .import.rio_xls(), and .import.rio_ods() respectively have the same problem.

May I submit a PR/s implementing the same argument-filtering for those functions? If yes, do you prefer a separate PR for each, or grouped together?
@bokov bokov referenced this issue Sep 19, 2019
Open
1 of 3 tasks complete
@leeper

This comment has been minimized.

Sign in to view
Copy link
Owner

commented Sep 21, 2019

Happy to have you tackle this! Your call on whether to submit separately or as one PR.

@leeper leeper added the enhancement label Sep 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@bokov @leeper
You can’t perform that action at this time.