Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[REVIEW]: SmartEDA: An R Package for Automated Exploratory Data Analysis #1509
Comments
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @nhejazi, @terrytangyuan it looks like you're currently assigned to review this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I saw that you submitted for review to JSS already https://arxiv.org/pdf/1903.04754.pdf. Is this submission to JOSS still necessary? |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Jun 20, 2019
•
@terrytangyuan Hi! We initially submitted the paper (given that it's a CRAN package) to JSS a couple of months back but it didn't work out there. We assure you that currently the paper is not under consideration for submission at any other journal or conference. We are hoping that this paper goes through the rigorous review and gets published at JOSS! |
This comment has been minimized.
This comment has been minimized.
@sayanddude I see. There are many other tools for (automated) exploratory data analysis in R. What makes this package useful/different? |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Jul 12, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Jul 12, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Jul 12, 2019
•
@terrytangyuan Hi! We have added a new section “Comparison with other R Packages” in the updated version of the paper pdf generated above. In this section we have given a snapshot of various capabilities of SmartEDA vs. some of the competing R packages (such as dlookr, explorer, DataExplorer, etc.) and have highlighted its advantages. Figure 9 in the paper gives a snapshot of the comparison and shows how it’s better than most of the available R packages for automated exploratory data analysis (Please find attached the figure below). To summarize, some of the key benefits of SmartEDA are: Also, SmartEDA is mentioned in the study conducted by Staniak and Biecek (2018) where they reviewed the landscape of R packages for automated Exploratory analysis. Some of the distinguishing features of SmartEDA pointed out by the authors when comparing it with other R packages are: Reference: |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Jul 12, 2019
•
@nhejazi @terrytangyuan Requesting the reviewers to kindly consider the latest version of the pdf generated above (10.21105.joss.01509.pdf). We have added a section on “Comparison with other R Packages” and corrected some formatting issues that were there in the earlier version. |
This comment has been minimized.
This comment has been minimized.
@sayanddude Thanks. The table looks great. Some feedback:
|
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Jul 12, 2019
•
@terrytangyuan Thanks for the feedback! I will work on your comments and will get back to you with the updated paper and the required code changes as soon as possible. |
This comment has been minimized.
This comment has been minimized.
@sayanddude — can you give us a status update? If you will need considerable more time, it would help if you let us know and we can add a "paused" label here. |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Aug 4, 2019
@labarba - Hi! We are almost done addressing all the comments of the reviewer. We are now at the final stages of creating the unit test for the package. Please give us a couple of more days, we will update the code repository along with the updated paper by Tuesday (6th Aug, 2019) end of the day. Thanks! |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Aug 6, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Aug 6, 2019
•
@terrytangyuan We have worked on addressing all of your comments. Please find below our response to each action items: • I see lots of long functions with >150 lines of code and the code style is not consistent (I suggest running a lintr check). Similarly, in the roxygen docs, the style is not consistent. I see both ##' and #'. The indentation levels and the roxygen syntax are sometimes incorrect. Please double check. • There isn't any unit test for the package. • Have you tried running this package on large datasets?. • Please make the paper more concise - I see many pages where each page only has one giant picture. Thanks and Regards, |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Aug 6, 2019
@labarba Hi! As discussed, we have completed working on the comments and have updated the Github code repository along with the paper. |
This comment has been minimized.
This comment has been minimized.
The handling editor, @mgymrek, will take it from here. |
This comment has been minimized.
This comment has been minimized.
mgymrek
commented
Aug 8, 2019
@sayanddude thanks for making these changes @nhejazi, @terrytangyuan can you now go over the revision? If your comments have been sufficiently addressed please finish filling out the checklist |
This comment has been minimized.
This comment has been minimized.
@sayanddude Thank you for quickly addressing our concerns, including the addition of the DOIs to all references (where possible). I've gone ahead and completed the reviewer checklist available to me and am ready to recommend the software paper for acceptance into JOSS. There may yet be other concerns to address but I do think the paper and R package are close. |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Aug 21, 2019
@nhejazi Thank you so much! |
This comment has been minimized.
This comment has been minimized.
mgymrek
commented
Sep 1, 2019
Thanks! @sayanddude see next steps below. Some minor comments on the paper:
After fixing those typos, can you please make a zenodo archive, being sure the title and author list match those on the paper, and report the DOI here? |
This comment has been minimized.
This comment has been minimized.
@sayanddude Thanks for addressing the comments. The paper looks good to me now and I recommend for publication. |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Sep 2, 2019
@terrytangyuan Thank you so much! |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Sep 2, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Sep 2, 2019
@mgymrek Thanks for the feedback! I have corrected all the required typos in the updated version of the pdf. I have ensured that the title and the author names are same as the ones mentioned in the paper. Please let me know if I have missed out on anything. Thank you so much! |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Sep 2, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mgymrek
commented
Sep 4, 2019
@whedon set 10.5281/zenodo.3383824 as archive |
This comment has been minimized.
This comment has been minimized.
OK. 10.5281/zenodo.3383824 is the archive. |
This comment has been minimized.
This comment has been minimized.
mgymrek
commented
Sep 4, 2019
@whedon set 0.3.2 as version |
This comment has been minimized.
This comment has been minimized.
OK. 0.3.2 is the version. |
This comment has been minimized.
This comment has been minimized.
mgymrek
commented
Sep 4, 2019
Thanks @sayanddude! |
This comment has been minimized.
This comment has been minimized.
@whedon accept |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#946, then you can now move forward with accepting the submission by compiling again with the flag
|
This comment has been minimized.
This comment has been minimized.
@whedon accept deposit=true |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
Here's what you must now do:
Any issues? notify your editorial technical team... |
This comment has been minimized.
This comment has been minimized.
sayanddude
commented
Sep 4, 2019
•
Thank you @mgymrek , @nhejazi and @terrytangyuan for guidance, support, and patience! It is much appreciated! |
This comment has been minimized.
This comment has been minimized.
@arfon Should we close this issue now that the paper has been deposited? |
This comment has been minimized.
This comment has been minimized.
danielskatz
commented
Sep 28, 2019
Yes |
This comment has been minimized.
This comment has been minimized.
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
whedon commentedJun 18, 2019
•
edited
Submitting author: @sayanddude (Sayan Putatunda)
Repository: https://github.com/daya6489/SmartEDA
Version: 0.3.2
Editor: @mgymrek
Reviewer: @nhejazi, @terrytangyuan
Archive: 10.5281/zenodo.3383824
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@nhejazi & @terrytangyuan , please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mgymrek know.
Review checklist for @nhejazi
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @terrytangyuan
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?