Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upThe `table` argument in `rio.db:::.import.rio_sqlite`: renaming or adding a `which` argument #5
Comments
This comment has been minimized.
This comment has been minimized.
|
Great idea. This was mostly proof-of-concept - I was never sure if I was actually going to put this on CRAN. Would be happy to have you collaborate on it, if you think it's useful. |
This comment has been minimized.
This comment has been minimized.
|
I absolutely think it's useful. One of my goals is to solve the "mystery file" problem and sqlite files are among the ones I've seen getting sent to researchers who have no idea how to open them. So are you okay with the simpler approach of renaming the second argument? |
This comment has been minimized.
This comment has been minimized.
|
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bokov commentedOct 4, 2019
Suggested enhancement for consistency with
rio.Here is the current call signature:
The
tableargument plays the same role here as thewhichargument does in all therioimport functions. If there aren't a lot of packages depending on this one (and maybe there aren't since this isn't on CRAN) then cantablebe renamed towhich?Otherwise, can we alter the call signature as follows?