Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference disambiguation in JASA style #4337

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@floriandenk
Copy link
Contributor

commented Oct 7, 2019

Bug fix: References to several papers from the same author and one year get disambigued (Author 2018a, 2018b) in citations, but not in the bibliography (a, b missing there). Fixed this issue by changing the appropriate macros in the bibliography generator.

Bug fix: References to several papers from the same author and one year get disambigued (Author 2018a, 2018b) in citations, but not in the bibliography (a, b missing there). Fixed this issue by changing the appropriate macros in tge bibliography generator.
@csl-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

😟 There are some issues with your submission.

1 test failed

the-journal-of-the-acoustical-society-of-america: may not have any unused macros

expected: []
     got: ["issued"]

(compared using ==)

Please check the test report for details.

@POBrien333

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@floriandenk
There is a way easier solution that also doesn't break the style.
all you need to do is add <text variable="year-suffix" to the issued macro.
So reverse those changes you made and add that.

@adam3smith

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

(looking at the style guide, switching to the issued-year macro actually does seem like the better choice. No sign of full dates anywhere)

@csl-bot

This comment has been minimized.

Copy link

commented Oct 8, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

the-journal-of-the-acoustical-society-of-america.csl (modified style)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example, (2012) Citation Style Editor, Available: http://editor.citationstyles.org/searchByExample/, (date last viewed: 15-Dec-12). Retrieved December 15, 2012, from http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., et al. (2019) “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 28. doi:10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., and Thatcher, M. (Eds.) (2007) Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York.
Mares, I. (2001) “Firms and the welfare state: When, why, and how does social policy matter to employers?,” In P. A. Hall and D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, pp. 184–213.
 (“CSL search by example,” 2012; Hancké et al., 2007)<br/>
 (Fenner et al., 2019; Mares, 2001)<br/>
 <hr/>
-<i>CSL search by example</i>, (<b>2012</b>). Citation Style Editor, Available: http://editor.citationstyles.org/searchByExample/, (date last viewed: 15-Dec-12). Retrieved December 15, 2012, from http://editor.citationstyles.org/searchByExample/<br/>
-Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., et al. (<b>2019</b>). “A data citation roadmap for scholarly data repositories,” Scientific Data, <b>6</b>, 28. doi:10.1038/s41597-019-0031-8<br/>
-Hancké, B., Rhodes, M., and Thatcher, M. (Eds.) (<b>2007</b>). <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>, Oxford University Press, Oxford and New York.<br/>
-Mares, I. (<b>2001</b>). “Firms and the welfare state: When, why, and how does social policy matter to employers?,” In P. A. Hall and D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, pp. 184–213.<br/>
+<i>CSL search by example</i>, (<b>2012</b>) Citation Style Editor, Available: http://editor.citationstyles.org/searchByExample/, (date last viewed: 15-Dec-12). Retrieved December 15, 2012, from http://editor.citationstyles.org/searchByExample/<br/>
+Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., et al. (<b>2019</b>) “A data citation roadmap for scholarly data repositories,” Scientific Data, <b>6</b>, 28. doi:10.1038/s41597-019-0031-8<br/>
+Hancké, B., Rhodes, M., and Thatcher, M. (Eds.) (<b>2007</b>) <i>Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy</i>, Oxford University Press, Oxford and New York.<br/>
+Mares, I. (<b>2001</b>) “Firms and the welfare state: When, why, and how does social policy matter to employers?,” In P. A. Hall and D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, pp. 184–213.<br/>
Clean up groups
@csl-bot

This comment has been minimized.

Copy link

commented Oct 8, 2019

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

the-journal-of-the-acoustical-society-of-america.csl (modified style; unchanged output for sample items)
(“CSL search by example,” 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example, (2012). Citation Style Editor, Available: http://editor.citationstyles.org/searchByExample/, (date last viewed: 15-Dec-12). Retrieved December 15, 2012, from http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., et al. (2019). “A data citation roadmap for scholarly data repositories,” Scientific Data, 6, 28. doi:10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., and Thatcher, M. (Eds.) (2007). Beyond varieties of capitalism : Conflict, contradiction, and complementarities in the European economy, Oxford University Press, Oxford and New York.
Mares, I. (2001). “Firms and the welfare state: When, why, and how does social policy matter to employers?,” In P. A. Hall and D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage, Oxford University Press, New York, pp. 184–213.
@adam3smith adam3smith merged commit 0e58112 into citation-style-language:master Oct 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.