Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pyHoops: A Python package for advanced basketball data analytics #1784

Open
whedon opened this issue Oct 4, 2019 · 42 comments

Comments

@whedon
Copy link
Collaborator

commented Oct 4, 2019

Submitting author: @alessandroBombelli (Alessandro Bombelli)
Repository: https://github.com/alessandroBombelli/pyHoops
Version: v1.5
Editor: @danielskatz
Reviewers: @mado89

Author instructions

Thanks for submitting your paper to JOSS @alessandroBombelli. Currently, there isn't an JOSS editor assigned to your paper.

@alessandroBombelli if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon whedon added the pre-review label Oct 4, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2019

Failed to discover a valid open source license.

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2019

PDF failed to compile for issue #1784 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon.rb:135:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon.rb:87:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-efe915e61673/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@kyleniemeyer

This comment has been minimized.

Copy link

commented Oct 4, 2019

Hello @alessandroBombelli, thanks for your interest in JOSS. Before we proceed, during my review of your submission, I could not find the research application of your software. While useful for folks in basketball, I don't quite see where someone would cite this in the academic literature (not an explicit requirement, but one way we think about whether software has a research use).

Can you clarify this, per one of our submission requirements?

The software should have an obvious research application.

@danielskatz

This comment has been minimized.

Copy link

commented Oct 4, 2019

alessandroBombelli/pyHoops#46 should fix the immediate paper building process

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 4, 2019

Hello @alessandroBombelli, thanks for your interest in JOSS. Before we proceed, during my review of your submission, I could not find the research application of your software. While useful for folks in basketball, I don't quite see where someone would cite this in the academic literature (not an explicit requirement, but one way we think about whether software has a research use).

Can you clarify this, per one of our submission requirements?

The software should have an obvious research application.

Dear @kyleniemeyer, apologies if the research application is not clear. I agree that, at a first glance, the obvious research application might not be as straight-forward as in other cases. On the other hand, a strong interest in data analytics applied to sports has been growing in recent years, as testified by ad-hoc conferences (MIT Sloan Sports Analytics Conference) and journals (Journal of Sports Sciences). To this avail, the research application of this work is the possibility to compute a set of team performance indices (per player and per lineup) to be used, as example, to infer lineup performances in future games. Knowing how different lineups perform against different opposing lineups (e.g., "tall", or "fast" lineups), can be used as part of a decision-making process to improve performances of a team. In addition, a sufficiently comprehensive database retrieved via pyHoops (e.g., a full season), can be used as the input for a prediction model (e.g., random forest) to assess what are the features (lineup- or player-specific) more crucial for a team's success. I hope this answers your question. I am willing to elaborate more if the answer is not satisfactory. Thank you!

@danielskatz

This comment has been minimized.

Copy link

commented Oct 4, 2019

I can take

@danielskatz danielskatz closed this Oct 4, 2019
@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 4, 2019

alessandroBombelli/pyHoops#46 should fix the immediate paper building process

Dear @danielskatz, sorry for the issue. but it is my first time here and, as such, I am not familiar with the formatting. I followed the example provided in the guidelines but thought that, being a single author, the distinction between affiliation and affiliations was not necessary. I fixed the issue now. Please let me know otherwise.
Thank you very much

@kyleniemeyer

This comment has been minimized.

Copy link

commented Oct 4, 2019

@danielskatz thanks for volunteering—did you mean to close the issue?

@kyleniemeyer

This comment has been minimized.

Copy link

commented Oct 4, 2019

@alessandroBombelli ok, so I think it would help to revise your article to better describe the research applications of the software, so this is clear to reviewers (and readers), focusing specifically on the types of research questions/problems this helps answer.

What you are describing to me sounds more like what a basketball team might use, but not an academic researcher writing a publication (for example)—but I may still be misunderstanding.

@danielskatz danielskatz reopened this Oct 4, 2019
@danielskatz

This comment has been minimized.

Copy link

commented Oct 4, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2019

@danielskatz

This comment has been minimized.

Copy link

commented Oct 4, 2019

I've suggested more changes in alessandroBombelli/pyHoops#48 - after merging this, you can enter @whedon generate pdf as a new comment here to regenerate the paper.

@kyleniemeyer

This comment has been minimized.

Copy link

commented Oct 4, 2019

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 4, 2019

OK, the editor is @danielskatz

@danielskatz

This comment has been minimized.

Copy link

commented Oct 7, 2019

@alessandroBombelli - do you have suggestions for reviewers? They can be from this list of potential reviewers (please start at the bottom of the list), or individuals who are not on this list; if so, please mention their GitHub handles here.

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

I've suggested more changes in alessandroBombelli/pyHoops#48 - after merging this, you can enter @whedon generate pdf as a new comment here to regenerate the paper.

@danielskatz, I slightly modified references because I realized two of them were not correctly compiled. In one case, there was a @ missing. In the other case, where I am citing a website, I am not sure what the problem is. I am using the same citation type I would use in a classic LaTeX file, where I know it should work. On the other hand, I am not very familiar with the integration of the .md file with the .bib file, so I have little control on what is going wrong. Could you please help me with that? Thanks!

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

I've suggested more changes in alessandroBombelli/pyHoops#48 - after merging this, you can enter @whedon generate pdf as a new comment here to regenerate the paper.

@danielskatz, I slightly modified references because I realized two of them were not correctly compiled. In one case, there was a @ missing. In the other case, where I am citing a website, I am not sure what the problem is. I am using the same citation type I would use in a classic LaTeX file, where I know it should work. On the other hand, I am not very familiar with the integration of the .md file with the .bib file, so I have little control on what is going wrong. Could you please help me with that? Thanks!

@danielskatz never mind, it is fixed now. Sorry for the confusion

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

@alessandroBombelli - do you have suggestions for reviewers? They can be from this list of potential reviewers (please start at the bottom of the list), or individuals who are not on this list; if so, please mention their GitHub handles here.

Dear @danielskatz, I checked the list and I think @mado89 should be a good match. No preference for the second reviewer instead.

@danielskatz

This comment has been minimized.

Copy link

commented Oct 8, 2019

Perhaps you can suggest some other people not on the list? Maybe from other types of sport analytics?

@danielskatz

This comment has been minimized.

Copy link

commented Oct 8, 2019

Also, for @Travassos, please add the DOI (https://doi.org/10.1080/24748668.2013.11868633)

@danielskatz

This comment has been minimized.

Copy link

commented Oct 8, 2019

👋 @mado89 - would you be willing to review this submission for JOSS?

@danielskatz

This comment has been minimized.

Copy link

commented Oct 8, 2019

👋 @ctsilva - would you (or someone in your group) be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

If not, could you suggest some others in the field of software and sports analytics who might be suitable?

@mado89

This comment has been minimized.

Copy link
Collaborator

commented Oct 8, 2019

@danielskatz I can do it. But I might need some time (and maybe a gentle reminder in 1.5 weeks) as I am quite busy this and next week.

@danielskatz

This comment has been minimized.

Copy link

commented Oct 8, 2019

Thanks @mado89 - we won't start until I find another reviewer, but I'll put you into the system for now, and I will be sure to remind you again once things start, or it's been a little time :)

@danielskatz

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon assign @mado89 as reviewer

@whedon whedon assigned danielskatz and mado89 and unassigned danielskatz Oct 8, 2019
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

OK, the reviewer is @mado89

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

PDF failed to compile for issue #1784 with the following error:

Error reading bibliography ./pyHoops_references.bib (line 18, column 3):
unexpected "p"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

@whedon generate pdf

@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

@alessandroBombelli

This comment has been minimized.

Copy link

commented Oct 8, 2019

Also, for @Travassos, please add the DOI (https://doi.org/10.1080/24748668.2013.11868633)

@danielskatz done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.