Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a title for the spectrum #5

Open
lfnothias opened this issue Oct 10, 2019 · 5 comments

Comments

@lfnothias
Copy link

commented Oct 10, 2019

Something like:
MS/MS spectrum of m/z 589.19 (scan = 100) - Orbitrap - UNI ID

@schymane

This comment has been minimized.

Copy link

commented Oct 10, 2019

That's quite long, but irrespective masses should be at least 4dp for Orbis, but the title should be as compact but informative as possible, substance name is good if short, if the text is searchable then bits of information should be separated in a way that's consistent, easily parsed and queried if possible ...

@sdrogers

This comment has been minimized.

Copy link
Collaborator

commented Oct 10, 2019

This is all doable, but we might need to specify what information we want from each data source, as they will all store different things. For the tools we maintain (GNPS, MS2LDA, etc) it would be easy enough to get the API to add a "title" key to the json and then just render this?

@sdrogers

This comment has been minimized.

Copy link
Collaborator

commented Oct 10, 2019

Just noticed that Ming has done massbank already...so if, e.g. the masbank API served a 'title' string as part of he data structure then we could render that easy peasy. I could add something for MS2LDA and motifdb...and I reckon pecursor m/z etc could be easily extracted from the massive records...

@schymane

This comment has been minimized.

Copy link

commented Oct 10, 2019

Otherwise a simple default is also "just" the spectral identifier ... might be a back up if no title available, as one can always use this to find the other info ...

@mwang87

This comment has been minimized.

Copy link
Owner

commented Oct 10, 2019

Perhaps we could list the spectrum identifier at the bottom if we can come up with a better title based on the resource?

@mwang87 mwang87 added this to the Release 3 milestone Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.