Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC-APCI-QTOF spectra to MassBank #97

Open
nalygizakis opened this issue Sep 13, 2019 · 7 comments

Comments

@nalygizakis
Copy link
Contributor

nalygizakis commented Sep 13, 2019

Hi @meier-rene @tsufz,

There is a project in NORMAN joint program of activities to upload GC-APCI-QTOF mass spectra in MassBank. I prepared for you one massbank record (https://www.dropbox.com/s/93z76o9bx243lll/AU230117.txt?dl=0), so that you apply the needed modifications to MassBank (if any).

Let me know if all is okay with the sample record, so that I give the signal for production of GC-APCI-QTOF records.

Thanks!
Nikiforos

@tsufz

This comment has been minimized.

Copy link
Member

tsufz commented Sep 13, 2019

HI @nalygizakis, Thanks for the initiative. I suggest to invent a complete new scheme for the GC based records. I will work on the record format and come back to you.

@tsufz tsufz self-assigned this Sep 13, 2019
@tsufz

This comment has been minimized.

Copy link
Member

tsufz commented Sep 13, 2019

Actually, we have already some examples of GC records such as https://massbank.eu/MassBank/RecordDisplay.jsp?id=MSJ01035&dsn=MSSJ.

@meier-rene, I guess all undocumented tages in MB records are provided in the undocumented subtag sections in https://github.com/MassBank/MassBank-web/blob/master/Documentation/MassBankRecordFormat.md?

@tsufz

This comment has been minimized.

Copy link
Member

tsufz commented Oct 28, 2019

@nalygizakis, I have now updated the record format and here are my suggestions to improve your record to be compliant with the record format version 2.4 (not published yet).

You can download my comments here:
AU230117_TS.docx

The draft record format 2.4 is found here:
https://github.com/tsufz/MassBank-web/blob/update_record_format/Documentation/MassBankRecordFormat.md

@tsufz

This comment has been minimized.

Copy link
Member

tsufz commented Oct 28, 2019

AU230117_TS.docx

Another Comment!

@nalygizakis

This comment has been minimized.

Copy link
Contributor Author

nalygizakis commented Oct 29, 2019

@tsufz I agree with the comments and improvements. I see some new fields in the record such as "SOURCE TEMPERATURE" or "TRANSFERLINE TEMPERATURE". Is there any chance to apply and integrate these improvements in RMassBank package? Of course, I can generate the records and add these details with a small script by myself. Let me know.

@tsufz

This comment has been minimized.

Copy link
Member

tsufz commented Oct 29, 2019

@nalygizakis By now, you need to infuse the new fields into the records by own code.

@schymane and @meowcat, we should keep in mind to integrate new tags into RMassBank. The Records Format is quite advanced now. I don't see many changes in future and thus IMHO it makes sense to update.

@schymane

This comment has been minimized.

Copy link
Member

schymane commented Oct 29, 2019

I think we will need to think about some functionality to deal with optional entries in the settings file. Some of the new changes are very specialised - some can be hard coded (i.e. set in the settings ini) but others will require data extraction (the full scan intensity and e.g. concentration, which would have to be provided up front in the compound list). Code changes non-trivial and capacities not clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.