Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upGC-APCI-QTOF spectra to MassBank #97
Comments
This comment has been minimized.
This comment has been minimized.
HI @nalygizakis, Thanks for the initiative. I suggest to invent a complete new scheme for the GC based records. I will work on the record format and come back to you. |
This comment has been minimized.
This comment has been minimized.
Actually, we have already some examples of GC records such as https://massbank.eu/MassBank/RecordDisplay.jsp?id=MSJ01035&dsn=MSSJ. @meier-rene, I guess all undocumented tages in MB records are provided in the |
This comment has been minimized.
This comment has been minimized.
@nalygizakis, I have now updated the record format and here are my suggestions to improve your record to be compliant with the record format version 2.4 (not published yet). You can download my comments here: The draft record format 2.4 is found here: |
This comment has been minimized.
This comment has been minimized.
Another Comment! |
This comment has been minimized.
This comment has been minimized.
@tsufz I agree with the comments and improvements. I see some new fields in the record such as "SOURCE TEMPERATURE" or "TRANSFERLINE TEMPERATURE". Is there any chance to apply and integrate these improvements in RMassBank package? Of course, I can generate the records and add these details with a small script by myself. Let me know. |
This comment has been minimized.
This comment has been minimized.
@nalygizakis By now, you need to infuse the new fields into the records by own code. @schymane and @meowcat, we should keep in mind to integrate new tags into RMassBank. The Records Format is quite advanced now. I don't see many changes in future and thus IMHO it makes sense to update. |
This comment has been minimized.
This comment has been minimized.
I think we will need to think about some functionality to deal with optional entries in the settings file. Some of the new changes are very specialised - some can be hard coded (i.e. set in the settings ini) but others will require data extraction (the full scan intensity and e.g. concentration, which would have to be provided up front in the compound list). Code changes non-trivial and capacities not clear? |
nalygizakis commentedSep 13, 2019
Hi @meier-rene @tsufz,
There is a project in NORMAN joint program of activities to upload GC-APCI-QTOF mass spectra in MassBank. I prepared for you one massbank record (https://www.dropbox.com/s/93z76o9bx243lll/AU230117.txt?dl=0), so that you apply the needed modifications to MassBank (if any).
Let me know if all is okay with the sample record, so that I give the signal for production of GC-APCI-QTOF records.
Thanks!
Nikiforos